RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-01-10 14:12:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[mips] Check for the correct error message in tests for interrupt attributes.

Browse Source 
Instead of XFAIL-ing the tests with the wrong usage of the "interrupt"
attribute, we should check that we emit the correct error messages to
the user.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251295 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Vasileios Kalintiris 2015-10-26 14:24:30 +00:00
parent bf7b3fed5c
commit 2df12188c5
8 changed files with 33 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Target/Mips/MipsISelLowering.cpp
View File

@ -2952,9 +2952,9 @@ MipsTargetLowering::LowerFormalArguments(SDValue Chain,
const Function *Func = DAG.getMachineFunction().getFunction();
Function::const_arg_iterator FuncArg = Func->arg_begin();
if (Func->hasFnAttribute("interrupt"))
assert(Func->arg_empty() &&
"Functions with the interrupt attribute cannot have arguments!");
if (Func->hasFnAttribute("interrupt") && !Func->arg_empty())
report_fatal_error(
"Functions with the interrupt attribute cannot have arguments!");
CCInfo.AnalyzeFormalArguments(Ins, CC_Mips_FixedArg);
MipsFI->setFormalArgInfo(CCInfo.getNextStackOffset(),

6
lib/Target/Mips/MipsSEFrameLowering.cpp
View File

@ -548,8 +548,8 @@ void MipsSEFrameLowering::emitInterruptPrologueStub(
// clearing is not provided so reject that configuration.
if (!STI.hasMips32r2())
report_fatal_error(
"\"interrupt\" attribute is not supported on pre-r2 MIPS or"
"Mips16 targets.");
"\"interrupt\" attribute is not supported on pre-MIPS32R2 or "
"MIPS16 targets.");
// The GP register contains the "user" value, so we cannot perform
// any gp relative loads until we restore the "kernel" or "system" gp
@ -561,7 +561,7 @@ void MipsSEFrameLowering::emitInterruptPrologueStub(
if (!STI.isABI_O32() || STI.hasMips64())
report_fatal_error("\"interrupt\" attribute is only supported for the "
"O32 ABI on MIPS32r2+ at the present time.");
"O32 ABI on MIPS32R2+ at the present time.");
// Perform ISR handling like GCC
StringRef IntKind =

9
test/CodeGen/Mips/interrupt-attr-64-error.ll Normal file
View File

@ -0,0 +1,9 @@
; RUN: not llc -mcpu=mips64r6 -march=mipsel -relocation-model=static < %s 2>%t
; RUN: FileCheck %s < %t
; CHECK: LLVM ERROR: "interrupt" attribute is only supported for the O32 ABI on MIPS32R2+ at the present time.
define i32 @isr_sw0() #0 {
ret i32 0
}
attributes #0 = { "interrupt"="sw0" }

11
test/CodeGen/Mips/interrupt-attr-64-fail.ll
View File

@ -1,11 +0,0 @@
; RUN: llc -mcpu=mips64r6 -march=mipsel -relocation-model=static -o - %s | FileCheck %s
; XFAIL: *
define void @isr_sw0() #0 {
call void bitcast (void (...)* @write to void ()*)()
}
declare void @write(...)
attributes #0 = { "interrupt"="sw0" }

9
test/CodeGen/Mips/interrupt-attr-args-error.ll Normal file
View File

@ -0,0 +1,9 @@
; RUN: not llc -mcpu=mips32r2 -march=mipsel -relocation-model=static < %s 2> %t
; RUN: FileCheck %s < %t
; CHECK: LLVM ERROR: Functions with the interrupt attribute cannot have arguments!
define i32 @isr_sw0(i8 signext %n) #0 {
ret i32 0
}
attributes #0 = { "interrupt"="sw0" }

11
test/CodeGen/Mips/interrupt-attr-args-fail.ll
View File

@ -1,11 +0,0 @@
; RUN: llc -mcpu=mips32r2 -march=mipsel -relocation-model=static -o - %s | FileCheck %s
; XFAIL: *
define void @isr_sw0(i8 signext %n) #0 {
call void bitcast (void (...)* @write to void ()*)()
}
declare void @write(...)
attributes #0 = { "interrupt"="sw0" }

9
test/CodeGen/Mips/interrupt-attr-error.ll Normal file
View File

@ -0,0 +1,9 @@
; RUN: not llc -mcpu=mips32 -march=mipsel -relocation-model=static < %s 2>%t
; RUN: FileCheck %s < %t
; CHECK: LLVM ERROR: "interrupt" attribute is not supported on pre-MIPS32R2 or MIPS16 targets.
define i32 @isr_sw0() #0 {
ret i32 0
}
attributes #0 = { "interrupt"="sw0" }

11
test/CodeGen/Mips/interrupt-attr-fail.ll
View File

@ -1,11 +0,0 @@
; RUN: llc -mcpu=mips32 -march=mipsel -relocation-model=static -o - %s | FileCheck %s
; XFAIL: *
define void @isr_sw0() #0 {
call void bitcast (void (...)* @write to void ()*)()
}
declare void @write(...)
attributes #0 = { "interrupt"="sw0" }