RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2024-12-03 17:32:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[CMake] Produce an empty library for GlobalISel when not building it.

Browse Source 
The rational for this change is that LLVMBuild cannot express conditional 
dependencies. Therefore, when we start optionally using GlobalISel library for 
say AArch64, without that change, all the tools that use the AArch64 library 
would need to explicitly link with GlobalISel when we ask for it.

This does not scale.

Instead, we will set the dependencies between the target and GlobalISel and if 
we did not ask to build GlobalISel, the library will just be empty.

Thanks to Chris Bieneman and Mehdi Animi for the idea.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@260566 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Quentin Colombet 2016-02-11 19:18:27 +00:00
parent 07b147db30
commit 317e76f08d
4 changed files with 40 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/CodeGen/CMakeLists.txt
View File

@ -143,6 +143,4 @@ add_dependencies(LLVMCodeGen intrinsics_gen)
add_subdirectory(SelectionDAG)
add_subdirectory(AsmPrinter)
add_subdirectory(MIRParser)
if(LLVM_BUILD_GLOBAL_ISEL)
add_subdirectory(GlobalISel)
endif()
add_subdirectory(GlobalISel)

22
lib/CodeGen/GlobalISel/CMakeLists.txt
View File

@ -1,6 +1,24 @@
# List of all GlobalISel files.
set(GLOBAL_ISEL_FILES
IRTranslator.cpp
MachineIRBuilder.cpp
)
# Add GlobalISel files to the dependencies if the user wants to build it.
if(LLVM_BUILD_GLOBAL_ISEL)
set(GLOBAL_ISEL_BUILD_FILES ${GLOBAL_ISEL_FILES})
else()
set(GLOBAL_ISEL_BUILD_FILES"")
set(LLVM_OPTIONAL_SOURCES LLVMGlobalISel ${GLOBAL_ISEL_FILES})
endif()
# In LLVMBuild.txt files, it is not possible to mark a dependency to a
# library as optional. So instead, generate an empty library if we did
# not ask for it.
add_llvm_library(LLVMGlobalISel
IRTranslator.cpp
MachineIRBuilder.cpp
${GLOBAL_ISEL_BUILD_FILES}
EmptyFile.cpp
)
add_dependencies(LLVMGlobalISel intrinsics_gen)

19
lib/CodeGen/GlobalISel/EmptyFile.cpp Normal file
View File

@ -0,0 +1,19 @@
//===-- llvm/CodeGen/GlobalISel/EmptyFile.cpp ------ EmptyFile ---*- C++ -*-==//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
/// \file
/// The purpose of this file is to please cmake by not creating an
/// empty library when we do not build GlobalISel.
/// \todo This file should be removed when GlobalISel is not optional anymore.
//===----------------------------------------------------------------------===//
// Anonymous namespace so that we do not step on anyone's toes.
namespace {
__attribute__ ((unused)) void foo(void) {
}
}

8
tools/llc/CMakeLists.txt
View File

@ -1,10 +1,3 @@
# Add GlobalISel to the dependencies if the user wants to build it.
if(LLVM_BUILD_GLOBAL_ISEL)
set(GLOBAL_ISEL GlobalISel)
else()
set(GLOBAL_ISEL "")
endif()
set(LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD}
Analysis
@ -12,7 +5,6 @@ set(LLVM_LINK_COMPONENTS
CodeGen
Core
IRReader
${GLOBAL_ISEL}
MC
MIRParser
ScalarOpts