RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2024-11-24 20:30:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[BitcodeReader] Ensure we can read constant vector selects with an i1 condition

Browse Source 
Summary:
Constant vectors weren't allowed to have an i1 condition in the
BitcodeReader. Make sure we have the same restrictions that are
documented, not more.

Reviewers: nlewycky, rafael, kschimpf

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D12440

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@246459 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Filipe Cabecinhas 2015-08-31 18:00:30 +00:00
parent 1318d71a75
commit 357ece4407
2 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Bitcode/Reader/BitcodeReader.cpp
View File

@ -2475,11 +2475,12 @@ std::error_code BitcodeReader::parseConstants() {
Type *SelectorTy = Type::getInt1Ty(Context);
// If CurTy is a vector of length n, then Record[0] must be a <n x i1>
// vector. Otherwise, it must be a single bit.
// The selector might be an i1 or an <n x i1>
// Get the type from the ValueList before getting a forward ref.
if (VectorType *VTy = dyn_cast<VectorType>(CurTy))
SelectorTy = VectorType::get(Type::getInt1Ty(Context),
VTy->getNumElements());
if (Value *V = ValueList[Record[0]])
if (SelectorTy != V->getType())
SelectorTy = VectorType::get(SelectorTy, VTy->getNumElements());
V = ConstantExpr::getSelect(ValueList.getConstantFwdRef(Record[0],
SelectorTy),

8
test/Bitcode/select.ll
View File

@ -8,3 +8,11 @@ define <2 x i32> @main() {
; CHECK: define <2 x i32> @main() {
; CHECK: ret <2 x i32> <i32 0, i32 undef>
; CHECK: }
define <2 x float> @f() {
ret <2 x float> select (i1 ptrtoint (<2 x float> ()* @f to i1), <2 x float> <float 1.000000e+00, float 0.000000e+00>, <2 x float> zeroinitializer)
}
; CHECK: define <2 x float> @f() {
; CHECK: ret <2 x float> select (i1 ptrtoint (<2 x float> ()* @f to i1), <2 x float> <float 1.000000e+00, float 0.000000e+00>, <2 x float> zeroinitializer)
; CHECK: }