diff --git a/lib/Transforms/IPO/ArgumentPromotion.cpp b/lib/Transforms/IPO/ArgumentPromotion.cpp index 49a67211db6..ea24d526942 100644 --- a/lib/Transforms/IPO/ArgumentPromotion.cpp +++ b/lib/Transforms/IPO/ArgumentPromotion.cpp @@ -807,6 +807,16 @@ CallGraphNode *ArgPromotion::DoPromotion(Function *F, I->replaceAllUsesWith(TheAlloca); TheAlloca->takeName(I); AA.replaceWithNewValue(I, TheAlloca); + + // If the alloca is used in a call, we must clear the tail flag since + // the callee now uses an alloca from the caller. + for (Value::use_iterator UI = TheAlloca->use_begin(), + E = TheAlloca->use_end(); UI != E; ++UI) { + CallInst *Call = dyn_cast(*UI); + if (!Call) + continue; + Call->setTailCall(false); + } continue; } diff --git a/test/Transforms/ArgumentPromotion/tail.ll b/test/Transforms/ArgumentPromotion/tail.ll new file mode 100644 index 00000000000..e6bc557d9d0 --- /dev/null +++ b/test/Transforms/ArgumentPromotion/tail.ll @@ -0,0 +1,19 @@ +; RUN: opt %s -argpromotion -S -o - | FileCheck %s + +%pair = type { i32, i32 } + +declare i8* @foo(%pair*) + +define internal void @bar(%pair* byval %Data) { +; CHECK: define internal void @bar(i32 %Data.0, i32 %Data.1) +; CHECK: %Data = alloca %pair +; CHECK-NOT: tail +; CHECK: call i8* @foo(%pair* %Data) + tail call i8* @foo(%pair* %Data) + ret void +} + +define void @zed(%pair* byval %Data) { + call void @bar(%pair* byval %Data) + ret void +}