From 37831d0a1202ab105b495762cb6cce7b6eb2438c Mon Sep 17 00:00:00 2001 From: Sanjiv Gupta Date: Thu, 9 Apr 2009 17:06:24 +0000 Subject: [PATCH] The way we are trying to figure out banksel immediate operand may yield different results for different type of insns. This will eventually need to be changed but currently let us prevent the crash in cases of incorrect detection of banksel operand. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@68713 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/PIC16/PIC16AsmPrinter.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/Target/PIC16/PIC16AsmPrinter.cpp b/lib/Target/PIC16/PIC16AsmPrinter.cpp index 2af42cd16d8..5c4b353294c 100644 --- a/lib/Target/PIC16/PIC16AsmPrinter.cpp +++ b/lib/Target/PIC16/PIC16AsmPrinter.cpp @@ -77,8 +77,9 @@ bool PIC16AsmPrinter::printMachineInstruction(const MachineInstr *MI) { // This is not true for external variables as section names for global // variables in all files are same at this time. For eg. initialized // data in put in idata.# section in all files. - if (((int)BS.getImm() == 1) && - ((Op.isGlobal() && Op.getGlobal()->hasExternalLinkage()) || + if ((BS.getType() == MachineOperand::MO_Immediate + && (int)BS.getImm() == 1) + && ((Op.isGlobal() && Op.getGlobal()->hasExternalLinkage()) || (NewBank.compare(CurBank) != 0))) { O << "\tbanksel "; printOperand(MI, BankSelVar);