Bring back r297624.

The issues was just a missing REQUIRES in the test.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@297661 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola 2017-03-13 20:00:25 +00:00
parent 33896dc120
commit 37e8db6fe5
3 changed files with 25 additions and 1 deletions

View File

@ -473,7 +473,7 @@ static int getFD(StringRef Filename, std::error_code &EC,
// possible.
if (!(Flags & sys::fs::F_Text))
sys::ChangeStdoutToBinary();
return STDOUT_FILENO;
return dup(STDOUT_FILENO);
}
int FD;

View File

@ -0,0 +1,16 @@
; REQUIRES: default_triple
; Often LLVM tools use "-" to indicate that output should be written to stdout
; instead of a file. This behaviour is implemented by the raw_fd_ostream class.
; This test verifies that when doing so multiple times we don't try to access a
; closed STDOUT_FILENO. The exact options used in this test are unimportant, as
; long as they write to stdout using raw_fd_ostream.
; RUN: llc %s -o=- -pass-remarks-output=- -filetype=asm | FileCheck %s
; foobar should appear as a function somewhere in the assembly file.
; CHECK: foobar
; !Analysis appears at the start of pass-remarks-output.
; CHECK: !Analysis
define void @foobar() {
ret void
}

View File

@ -9,6 +9,7 @@
#include "gtest/gtest.h"
#include "llvm/ADT/SmallString.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/Format.h"
#include "llvm/Support/raw_ostream.h"
@ -330,4 +331,11 @@ TEST(raw_ostreamTest, FormattedHexBytes) {
"0007: 68 69 6a 6b 6c |hijkl|",
format_bytes_with_ascii_str(B.take_front(12), 0, 7, 1));
}
TEST(raw_fd_ostreamTest, multiple_raw_fd_ostream_to_stdout) {
std::error_code EC;
{ raw_fd_ostream("-", EC, sys::fs::OpenFlags::F_None); }
{ raw_fd_ostream("-", EC, sys::fs::OpenFlags::F_None); }
}
}