RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-04-03 05:41:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix an issue where LSR would miss rewriting a use of an IV expression by a PHI node that is not the original PHI.

Browse Source 
This fixes up a dot-product loop in galgel, speeding it up from 18.47s to
16.13s.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@23327 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2005-09-13 02:09:55 +00:00
parent c6342355c9
commit 396b2baf3c
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Transforms/Scalar/LoopStrengthReduce.cpp
View File

@ -333,14 +333,14 @@ bool LoopStrengthReduce::AddUsersIfInteresting(Instruction *I, Loop *L,
Instruction *User = cast<Instruction>(*UI); Instruction *User = cast<Instruction>(*UI);
// Do not infinitely recurse on PHI nodes. // Do not infinitely recurse on PHI nodes.
if (isa<PHINode>(User) && User->getParent() == L->getHeader()) if (isa<PHINode>(User) && Processed.count(User))
continue; continue;
// If this is an instruction defined in a nested loop, or outside this loop, // If this is an instruction defined in a nested loop, or outside this loop,
// don't recurse into it. // don't recurse into it.
bool AddUserToIVUsers = false; bool AddUserToIVUsers = false;
if (LI->getLoopFor(User->getParent()) != L) { if (LI->getLoopFor(User->getParent()) != L) {
DEBUG(std::cerr << "FOUND USER in nested loop: " << *User DEBUG(std::cerr << "FOUND USER in other loop: " << *User
<< " OF SCEV: " << *ISE << "\n"); << " OF SCEV: " << *ISE << "\n");
AddUserToIVUsers = true; AddUserToIVUsers = true;
} else if (!AddUsersIfInteresting(User, L, Processed)) { } else if (!AddUsersIfInteresting(User, L, Processed)) {
@ -459,9 +459,13 @@ void BasedUser::RewriteInstructionToUseNewBase(const SCEVHandle &NewBase,
for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) { for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) {
if (PN->getIncomingValue(i) == OperandValToReplace) { if (PN->getIncomingValue(i) == OperandValToReplace) {
// If this is a critical edge, split the edge so that we do not insert the // If this is a critical edge, split the edge so that we do not insert the
// code on all predecessor/successor paths. // code on all predecessor/successor paths. We do this unless this is the
// canonical backedge for this loop, as this can make some inserted code
// be in an illegal position.
if (e != 1 && if (e != 1 &&
PN->getIncomingBlock(i)->getTerminator()->getNumSuccessors() > 1) { PN->getIncomingBlock(i)->getTerminator()->getNumSuccessors() > 1 &&
(PN->getParent() != L->getHeader() ||
!L->contains(PN->getIncomingBlock(i)))) {
// First step, split the critical edge. // First step, split the critical edge.
SplitCriticalEdge(PN->getIncomingBlock(i), PN->getParent(), P); SplitCriticalEdge(PN->getIncomingBlock(i), PN->getParent(), P);