RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-04-03 05:41:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix some abuses of StringRef

Browse Source 
We were taking a StringRef to a temporary result, which can go horribly wrong.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@174328 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Tim Northover 2013-02-04 15:44:38 +00:00
parent a220aeb58f
commit 42a68443a1
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
View File

@ -1207,8 +1207,8 @@ AArch64AsmParser::ParseRelocPrefix(AArch64MCExpr::VariantKind &RefKind) {
return MatchOperand_ParseFail; return MatchOperand_ParseFail;
} }
StringRef lowerCase = Parser.getTok().getIdentifier().lower(); std::string LowerCase = Parser.getTok().getIdentifier().lower();
RefKind = StringSwitch<AArch64MCExpr::VariantKind>(lowerCase) RefKind = StringSwitch<AArch64MCExpr::VariantKind>(LowerCase)
.Case("got", AArch64MCExpr::VK_AARCH64_GOT) .Case("got", AArch64MCExpr::VK_AARCH64_GOT)
.Case("got_lo12", AArch64MCExpr::VK_AARCH64_GOT_LO12) .Case("got_lo12", AArch64MCExpr::VK_AARCH64_GOT_LO12)
.Case("lo12", AArch64MCExpr::VK_AARCH64_LO12) .Case("lo12", AArch64MCExpr::VK_AARCH64_LO12)
@ -1343,7 +1343,8 @@ AArch64AsmParser::ParseCRxOperand(
return MatchOperand_ParseFail; return MatchOperand_ParseFail;
} }
StringRef Tok = Parser.getTok().getIdentifier().lower(); std::string LowerTok = Parser.getTok().getIdentifier().lower();
StringRef Tok(LowerTok);
if (Tok[0] != 'c') { if (Tok[0] != 'c') {
Error(S, "Expected cN operand where 0 <= N <= 15"); Error(S, "Expected cN operand where 0 <= N <= 15");
return MatchOperand_ParseFail; return MatchOperand_ParseFail;