RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2024-12-22 20:20:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Incorporate feedback.

Browse Source 
- Fix loop nest.
- Use RetVals.size()
- Check for null return value.



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@48605 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Devang Patel 2008-03-20 18:30:32 +00:00
parent 69cf031ee3
commit 488b678a49
1 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
lib/Transforms/IPO/IPConstantPropagation.cpp
View File

@ -144,19 +144,17 @@ bool IPCP::PropagateConstantReturn(Function &F) {
// Check to see if this function returns a constant.
SmallVector<Value *,4> RetVals;
unsigned N = 0;
const StructType *STy = dyn_cast<StructType>(F.getReturnType());
if (STy)
N = STy->getNumElements();
RetVals.assign(STy->getNumElements(), 0);
else
N = 1;
for (unsigned i = 0; i < N; ++i)
RetVals.push_back(0);
for (Function::iterator BB = F.begin(), E = F.end(); BB != E; ++BB)
if (ReturnInst *RI = dyn_cast<ReturnInst>(BB->getTerminator())) {
assert (N == RI->getNumOperands() && "Invalid ReturnInst operands!");
for (unsigned i = 0; i < N; ++i) {
unsigned RetValsSize = RetVals.size();
assert (RetValsSize == RI->getNumOperands() && "Invalid ReturnInst operands!");
for (unsigned i = 0; i < RetValsSize; ++i) {
if (isa<UndefValue>(RI->getOperand(i))) {
// Ignore
} else if (Constant *C = dyn_cast<Constant>(RI->getOperand(i))) {
@ -171,15 +169,14 @@ bool IPCP::PropagateConstantReturn(Function &F) {
}
}
if (N == 1) {
if (RetVals[0] == 0)
RetVals[0] = UndefValue::get(F.getReturnType());
} else {
for (unsigned i = 0; i < N; ++i) {
Value *RetVal = RetVals[i];
if (RetVal == 0)
if (STy) {
for (unsigned i = 0, e = RetVals.size(); i < e; ++i)
if (RetVals[i] == 0)
RetVals[i] = UndefValue::get(STy->getElementType(i));
}
} else {
if (RetVals.size() == 1)
if (RetVals[0] == 0)
RetVals[0] = UndefValue::get(F.getReturnType());
}
// If we got here, the function returns a constant value. Loop over all
@ -197,14 +194,16 @@ bool IPCP::PropagateConstantReturn(Function &F) {
} else {
Instruction *Call = CS.getInstruction();
if (!Call->use_empty()) {
if (N == 1)
if (RetVals.size() == 1)
Call->replaceAllUsesWith(RetVals[0]);
else {
for(Value::use_iterator CUI = Call->use_begin(), CUE = Call->use_end();
CUI != CUE; ++CUI) {
GetResultInst *GR = cast<GetResultInst>(CUI);
GR->replaceAllUsesWith(RetVals[GR->getIndex()]);
GR->eraseFromParent();
if (RetVals[GR->getIndex()]) {
GR->replaceAllUsesWith(RetVals[GR->getIndex()]);
GR->eraseFromParent();
}
}
}
MadeChange = true;
@ -216,18 +215,19 @@ bool IPCP::PropagateConstantReturn(Function &F) {
// other callers of the function, replace the constant being returned in the
// function with an undef value.
if (ReplacedAllUsers && F.hasInternalLinkage()) {
for (unsigned i = 0; i < N; ++i) {
Value *RetVal = RetVals[i];
if (isa<UndefValue>(RetVal))
continue;
Value *RV = UndefValue::get(RetVal->getType());
for (Function::iterator BB = F.begin(), E = F.end(); BB != E; ++BB)
if (ReturnInst *RI = dyn_cast<ReturnInst>(BB->getTerminator())) {
for (Function::iterator BB = F.begin(), E = F.end(); BB != E; ++BB) {
if (ReturnInst *RI = dyn_cast<ReturnInst>(BB->getTerminator())) {
for (unsigned i = 0, e = RetVals.size(); i < e; ++i) {
Value *RetVal = RetVals[i];
if (isa<UndefValue>(RetVal))
continue;
Value *RV = UndefValue::get(RetVal->getType());
if (RI->getOperand(i) != RV) {
RI->setOperand(i, RV);
MadeChange = true;
}
}
}
}
}