diff --git a/lib/Analysis/DataStructure/BottomUpClosure.cpp b/lib/Analysis/DataStructure/BottomUpClosure.cpp index d8ae1de7be0..c7fb42d860e 100644 --- a/lib/Analysis/DataStructure/BottomUpClosure.cpp +++ b/lib/Analysis/DataStructure/BottomUpClosure.cpp @@ -344,8 +344,9 @@ DSGraph &BUDataStructures::calculateGraph(Function &F) { #endif // Handle self recursion by resolving the arguments and return value - Graph.mergeInGraph(CS, GI, DSGraph::StripAllocaBit | - DSGraph::DontCloneCallNodes); + Graph.mergeInGraph(CS, GI, + DSGraph::KeepModRefBits | + DSGraph::StripAllocaBit | DSGraph::DontCloneCallNodes); #if 0 Graph.writeGraphToFile(std::cerr, "bu_" + F.getName() + "_after_" + @@ -424,7 +425,8 @@ DSGraph &BUDataStructures::inlineNonSCCGraphs(Function &F, << GI.getAuxFunctionCalls().size() << "]\n"); // Handle self recursion by resolving the arguments and return value - Graph.mergeInGraph(CS, GI, DSGraph::StripAllocaBit | + Graph.mergeInGraph(CS, GI, + DSGraph::KeepModRefBits | DSGraph::StripAllocaBit | DSGraph::DontCloneCallNodes); } } @@ -508,7 +510,8 @@ DSGraph &BUDataStructures::calculateSCCGraph(Function &F, << GI.getAuxFunctionCalls().size() << "]\n"); // Handle self recursion by resolving the arguments and return value - Graph.mergeInGraph(CS, GI, DSGraph::StripAllocaBit | + Graph.mergeInGraph(CS, GI, + DSGraph::KeepModRefBits | DSGraph::StripAllocaBit | DSGraph::DontCloneCallNodes); if (SCCFunctions.count(Callee)) diff --git a/lib/Analysis/DataStructure/DataStructure.cpp b/lib/Analysis/DataStructure/DataStructure.cpp index fe72bfe6d52..d26213fc482 100644 --- a/lib/Analysis/DataStructure/DataStructure.cpp +++ b/lib/Analysis/DataStructure/DataStructure.cpp @@ -598,9 +598,14 @@ DSNodeHandle DSGraph::cloneInto(const DSGraph &G, Nodes[i]->remapLinks(OldNodeMap); // Remove alloca markers as specified - if (CloneFlags & StripAllocaBit) + if (CloneFlags & (StripAllocaBit | StripModRefBits)) { + unsigned short clearBits = (CloneFlags & StripAllocaBit + ? DSNode::AllocaNode : 0) + | (CloneFlags & StripModRefBits + ? (DSNode::Modified | DSNode::Read) : 0); for (unsigned i = FN, e = Nodes.size(); i != e; ++i) - Nodes[i]->NodeType &= ~DSNode::AllocaNode; + Nodes[i]->NodeType &= ~clearBits; + } // Copy the value map... and merge all of the global nodes... for (std::map::const_iterator I = G.ScalarMap.begin(), diff --git a/lib/Analysis/DataStructure/TopDownClosure.cpp b/lib/Analysis/DataStructure/TopDownClosure.cpp index aa9a6a94c6c..da9bc7c1348 100644 --- a/lib/Analysis/DataStructure/TopDownClosure.cpp +++ b/lib/Analysis/DataStructure/TopDownClosure.cpp @@ -100,7 +100,7 @@ void TDDataStructures::calculateGraph(Function &F) { const std::vector &CallSites = Graph.getFunctionCalls(); if (CallSites.empty()) { DEBUG(std::cerr << " [TD] No callees for: " << F.getName() << "\n"); - return; // If no call sites, the graph is the same as the BU graph! + return; // If no call sites, there is nothing more to do here } // Loop over all of the call sites, building a multi-map from Callees to @@ -143,9 +143,10 @@ void TDDataStructures::calculateGraph(Function &F) { std::map OldValMap; std::map OldNodeMap; CG.cloneInto(Graph, OldValMap, OldNodeMap, + DSGraph::StripModRefBits | DSGraph::KeepAllocaBit | DSGraph::DontCloneCallNodes); OldValMap.clear(); // We don't care about the ValMap - + // Loop over all of the invocation sites of the callee, resolving // arguments to our graph. This loop may iterate multiple times if the // current function calls this callee multiple times with different