RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-01-18 16:03:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix a type mismatch assert in SCEV division

Browse Source 
An assert was triggered when attempting to create a new SCEV
with operands of different types in the visitAddRecExpr. In this
test case, the operand types of the numerator and denominator
are different. The SCEV division code should generate a
conservative answer when this happens.

Differential Revision: http://reviews.llvm.org/D9021


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@235511 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Brendon Cahoon 2015-04-22 15:06:40 +00:00
parent 6c347524e2
commit 8b94db17a4
2 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/Analysis/ScalarEvolution.cpp
View File

@ -795,6 +795,14 @@ public:
assert(Numerator->isAffine() && "Numerator should be affine");
divide(SE, Numerator->getStart(), Denominator, &StartQ, &StartR);
divide(SE, Numerator->getStepRecurrence(SE), Denominator, &StepQ, &StepR);
// Bail out if the types do not match.
Type *Ty = Denominator->getType();
if (Ty != StartQ->getType() || Ty != StartR->getType() ||
Ty != StepQ->getType() || Ty != StepR->getType()) {
Quotient = Zero;
Remainder = Numerator;
return;
}
Quotient = SE.getAddRecExpr(StartQ, StepQ, Numerator->getLoop(),
Numerator->getNoWrapFlags());
Remainder = SE.getAddRecExpr(StartR, StepR, Numerator->getLoop(),

29
test/Analysis/Delinearization/type_mismatch.ll Normal file
View File

@ -0,0 +1,29 @@
; RUN: opt < %s -analyze -delinearize
; REQUIRES: asserts
; Test that SCEV divide code doesn't crash when attempting to create a SCEV
; with operands of different types. In this case, the visitAddRecExpr
; function tries to create an AddRec where the start and step are different
; types.
target datalayout = "e-m:e-p:32:32-i64:64-a:0-v32:32-n16:32"
define fastcc void @test() {
entry:
%0 = load i16, i16* undef, align 2
%conv21 = zext i16 %0 to i32
br label %for.cond7.preheader
for.cond7.preheader:
%p1.022 = phi i8* [ undef, %entry ], [ %add.ptr, %for.end ]
br label %for.body11
for.body11:
%arrayidx.phi = phi i8* [ %p1.022, %for.cond7.preheader ], [ undef, %for.body11 ]
store i8 undef, i8* %arrayidx.phi, align 1
br i1 undef, label %for.body11, label %for.end
for.end:
%add.ptr = getelementptr inbounds i8, i8* %p1.022, i32 %conv21
br label %for.cond7.preheader
}