Weight loop unrolling counts by nesting depth. Unrolling deeply nested loops tends to cause high

register pressure and thus excess spills, which we don't currently recover from well.  This should
be re-evaluated in the future if our ability to generate good spills/splits improves.

Partial fix for <rdar://problem/7635585>.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@114919 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Owen Anderson 2010-09-27 22:58:54 +00:00
parent 385cc5eede
commit 8d9e92ce2d

View File

@ -158,7 +158,12 @@ bool LoopUnroll::runOnLoop(Loop *L, LPPassManager &LPM) {
DEBUG(dbgs() << " Not unrolling loop with inlinable calls.\n");
return false;
}
uint64_t Size = (uint64_t)LoopSize*Count;
// NOTE: We multiply by the loop depth because unrolling inner loops of
// very deep nests tends to result in high register pressure, which we don't
// currently recover from very well. When and if the register allocator/
// spiller improves to compensate, this should be re-evaluated.
uint64_t Size = (uint64_t)LoopSize*Count*L->getLoopDepth();
if (TripCount != 1 && Size > CurrentThreshold) {
DEBUG(dbgs() << " Too large to fully unroll with count: " << Count
<< " because size: " << Size << ">" << CurrentThreshold << "\n");