RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2026-07-19 23:23:38 -04:00
Code Issues Packages Projects Releases 10 Wiki Activity

[Option] Store arg strings in a set backed by a BumpPtrAllocator

Browse Source 
No functionality change.

This is preparing to move response file parsing into lib/Option so it
can be shared between clang and lld.  This change isn't just a
micro-optimization.  Clang's driver uses a std::set<std::string> to
unique arguments while parsing response files, so this matches that.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@186319 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Reid Kleckner
2013-07-15 13:46:24 +00:00
parent 4c275c31aa
commit 95695c8bb3
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Option/ArgList.cpp
+11 -2
View File
@@ -323,9 +323,18 @@ InputArgList::~InputArgList() {
unsigned InputArgList::MakeIndex(StringRef String0) const {
unsigned Index = ArgStrings.size();
// If necessary, make a copy so we can null terminate it.
std::string NullTerminated;
if (String0.back() != '\0') {
NullTerminated.append(String0.data(), String0.size());
NullTerminated.push_back('\0');
String0 = StringRef(&NullTerminated[0], NullTerminated.size());
}
// Tuck away so we have a reliable const char *.
SynthesizedStrings.push_back(String0);
ArgStrings.push_back(SynthesizedStrings.back().c_str());
String0 = SynthesizedStrings.GetOrCreateValue(String0).getKey();
assert(String0.back() == '\0');
ArgStrings.push_back(String0.data());
return Index;
}