mirror of
https://github.com/RPCS3/llvm.git
synced 2026-07-19 15:13:49 -04:00
[lib/Analysis] - Mark personality functions as live.
This is PR33245. Case I am fixing is next: Imagine we have 2 BC files, one defines and uses personality routine, second has only declaration and also uses it. Previously algorithm computing dead symbols (llvm::computeDeadSymbols) did not know about personality routines and leaved them dead even if function that has routine was live. As a result thinLTOInternalizeAndPromoteGUID() method changed binding for such symbol to local. Later when LLD tried to link these objects it failed because one object had undefined global symbol for routine and second object contained local definition instead of global. Patch set the live root flag on the corresponding FunctionSummary for personality routines when we build the per-module summaries during the compile step. Differential revision: https://reviews.llvm.org/D36834 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@311432 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
@@ -403,6 +403,12 @@ ModuleSummaryIndex llvm::buildModuleSummaryIndex(
|
||||
CantBePromoted);
|
||||
}
|
||||
|
||||
// Set live flag for all personality functions. That allows to
|
||||
// preserve them during DCE.
|
||||
for (const llvm::Function &F : M)
|
||||
if (!F.isDeclaration() && F.hasPersonalityFn())
|
||||
setLiveRoot(Index, F.getPersonalityFn()->getName());
|
||||
|
||||
// Compute summaries for all variables defined in module, and save in the
|
||||
// index.
|
||||
for (const GlobalVariable &G : M.globals()) {
|
||||
|
||||
Reference in New Issue
Block a user