From 986392e6e74f4f14c9f6375ed79b484dc5df7615 Mon Sep 17 00:00:00 2001 From: Timur Iskhodzhanov Date: Tue, 8 Jul 2014 13:18:58 +0000 Subject: [PATCH] [ASan/Win] Don't instrument private COMDAT globals until PR20244 is properly fixed git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@212530 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Instrumentation/AddressSanitizer.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/Transforms/Instrumentation/AddressSanitizer.cpp b/lib/Transforms/Instrumentation/AddressSanitizer.cpp index 65f769cf16e..8f9355cb831 100644 --- a/lib/Transforms/Instrumentation/AddressSanitizer.cpp +++ b/lib/Transforms/Instrumentation/AddressSanitizer.cpp @@ -946,6 +946,13 @@ bool AddressSanitizerModule::ShouldInstrumentGlobal(GlobalVariable *G) { return false; } + // Don't instrument private COMDAT globals on Windows until PR20244 (linkage + // of vftables with RTTI) is properly fixed. + llvm::Triple TargetTriple(G->getParent()->getTargetTriple()); + if (G->hasComdat() && G->getLinkage() == GlobalVariable::PrivateLinkage && + TargetTriple.isWindowsMSVCEnvironment()) + return false; + if (G->hasSection()) { StringRef Section(G->getSection()); // Ignore the globals from the __OBJC section. The ObjC runtime assumes