RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2024-12-17 00:50:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added a description of the algorithm.

Browse Source 
Return failure if the chmod() fails.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@8326 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
John Criswell 2003-09-02 20:30:16 +00:00
parent d35b5b542d
commit 9adeccc552
2 changed files with 28 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/Support/FileUtilities.cpp
View File

@ -98,12 +98,14 @@ std::string getUniqueFilename(const std::string &FilenameBase) {
///
/// Description:
/// This method makes the specified filename executable by giving it
/// execute permission.
/// execute permission. It respects the umask value of the process, and it
/// does not enable any unnecessary access bits.
///
/// For the UNIX version of this method, we turn on all of the read and
/// execute bits and then turn off anything specified in the umask. This
/// should help ensure that access to the file remains at the level that
/// the user desires.
/// Algorithm:
/// o Get file's current permissions.
/// o Get the process's current umask.
/// o Take the set of all execute bits and disable those found in the umask.
/// o Add the remaining permissions to the file's permissions.
///
bool
MakeFileExecutable (const std::string & Filename)
@ -134,8 +136,13 @@ MakeFileExecutable (const std::string & Filename)
return false;
}
// Make the script executable...
chmod(Filename.c_str(), (fstat.st_mode | (0111 & ~mask)));
//
// Make the file executable...
//
if ((chmod(Filename.c_str(), (fstat.st_mode | (0111 & ~mask)))) == -1)
{
return false;
}
return true;
}

21
support/lib/Support/FileUtilities.cpp
View File

@ -98,12 +98,14 @@ std::string getUniqueFilename(const std::string &FilenameBase) {
///
/// Description:
/// This method makes the specified filename executable by giving it
/// execute permission.
/// execute permission. It respects the umask value of the process, and it
/// does not enable any unnecessary access bits.
///
/// For the UNIX version of this method, we turn on all of the read and
/// execute bits and then turn off anything specified in the umask. This
/// should help ensure that access to the file remains at the level that
/// the user desires.
/// Algorithm:
/// o Get file's current permissions.
/// o Get the process's current umask.
/// o Take the set of all execute bits and disable those found in the umask.
/// o Add the remaining permissions to the file's permissions.
///
bool
MakeFileExecutable (const std::string & Filename)
@ -134,8 +136,13 @@ MakeFileExecutable (const std::string & Filename)
return false;
}
// Make the script executable...
chmod(Filename.c_str(), (fstat.st_mode | (0111 & ~mask)));
//
// Make the file executable...
//
if ((chmod(Filename.c_str(), (fstat.st_mode | (0111 & ~mask)))) == -1)
{
return false;
}
return true;
}