RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-01-02 17:58:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GlobalDCE: Fix an oversight in my last commit that could lead to crashes.

Browse Source 
There is a Constant with non-constant operands: blockaddress.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@179460 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Benjamin Kramer 2013-04-13 16:11:14 +00:00
parent 8848680ce0
commit 9cbee63b1a
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Transforms/IPO/GlobalDCE.cpp
View File

@ -197,8 +197,8 @@ void GlobalDCE::MarkUsedGlobalsAsNeeded(Constant *C) {
// use to the list of needed globals. // use to the list of needed globals.
for (User::op_iterator I = C->op_begin(), E = C->op_end(); I != E; ++I) { for (User::op_iterator I = C->op_begin(), E = C->op_end(); I != E; ++I) {
// If we've already processed this constant there's no need to do it again. // If we've already processed this constant there's no need to do it again.
Constant *Op = cast<Constant>(*I); Constant *Op = dyn_cast<Constant>(*I);
if (SeenConstants.insert(Op)) if (Op && SeenConstants.insert(Op))
MarkUsedGlobalsAsNeeded(Op); MarkUsedGlobalsAsNeeded(Op);
} }
} }

18
test/Transforms/GlobalDCE/indirectbr.ll Normal file
View File

@ -0,0 +1,18 @@
; RUN: opt -S -globaldce < %s | FileCheck %s
@L = internal unnamed_addr constant [3 x i8*] [i8* blockaddress(@test1, %L1), i8* blockaddress(@test1, %L2), i8* null], align 16
; CHECK: @L = internal unnamed_addr constant
define void @test1(i32 %idx) {
entry:
br label %L1
L1:
%arrayidx = getelementptr inbounds [3 x i8*]* @L, i32 0, i32 %idx
%l = load i8** %arrayidx
indirectbr i8* %l, [label %L1, label %L2]
L2:
ret void
}