RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-02-11 05:17:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Handle a corner case when extracing code regions where one of the immediate successor

Browse Source 
of an extracted block contains a PHI using a value defined in the extracted region.

With this patch, the partial inliner now passes MultiSource/Applications.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@79963 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Owen Anderson 2009-08-25 00:54:39 +00:00
parent f6163dc856
commit 9db7e91fe8
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/Transforms/Utils/CodeExtractor.cpp
View File

@ -369,7 +369,7 @@ emitCallAndSwitchStatement(Function *newFunction, BasicBlock *codeReplacer,
Values &inputs, Values &outputs) { Values &inputs, Values &outputs) {
// Emit a call to the new function, passing in: *pointer to struct (if // Emit a call to the new function, passing in: *pointer to struct (if
// aggregating parameters), or plan inputs and allocated memory for outputs // aggregating parameters), or plan inputs and allocated memory for outputs
std::vector<Value*> params, StructValues, ReloadOutputs; std::vector<Value*> params, StructValues, ReloadOutputs, Reloads;
LLVMContext &Context = newFunction->getContext(); LLVMContext &Context = newFunction->getContext();
@ -446,6 +446,7 @@ emitCallAndSwitchStatement(Function *newFunction, BasicBlock *codeReplacer,
Output = ReloadOutputs[i]; Output = ReloadOutputs[i];
} }
LoadInst *load = new LoadInst(Output, outputs[i]->getName()+".reload"); LoadInst *load = new LoadInst(Output, outputs[i]->getName()+".reload");
Reloads.push_back(load);
codeReplacer->getInstList().push_back(load); codeReplacer->getInstList().push_back(load);
std::vector<User*> Users(outputs[i]->use_begin(), outputs[i]->use_end()); std::vector<User*> Users(outputs[i]->use_begin(), outputs[i]->use_end());
for (unsigned u = 0, e = Users.size(); u != e; ++u) { for (unsigned u = 0, e = Users.size(); u != e; ++u) {
@ -532,8 +533,25 @@ emitCallAndSwitchStatement(Function *newFunction, BasicBlock *codeReplacer,
DominatesDef = false; DominatesDef = false;
} }
if (DT) if (DT) {
DominatesDef = DT->dominates(DefBlock, OldTarget); DominatesDef = DT->dominates(DefBlock, OldTarget);
// If the output value is used by a phi in the target block,
// then we need to test for dominance of the phi's predecessor
// instead. Unfortunately, this a little complicated since we
// have already rewritten uses of the value to uses of the reload.
for (Value::use_iterator UI = Reloads[out]->use_begin(),
UE = Reloads[out]->use_end(); UI != UE; ++UI) {
PHINode *P = dyn_cast<PHINode>(*UI);
if (!P || P->getParent() != OldTarget) continue;
BasicBlock* pred = P->getIncomingBlock(UI);
if (DT->dominates(DefBlock, pred)) {
DominatesDef = true;
break;
}
}
}
if (DominatesDef) { if (DominatesDef) {
if (AggregateArgs) { if (AggregateArgs) {