RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-02-20 10:41:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix bug in test-release.sh where the script would not exit if any

Browse Source 
of the build stages that are sent through a pipe (e.g. tee) failed.

This potentially allowed builds and/or tests to fail without anyone
noticing. It appears that for the LLVM 3.6.[01] releases this actually
happened for the Ubuntu 14.04LTS binary releases. The essence of the
issue is that without ``set -o pipefail`` the following command in bash
has a zero exit code.

false | tee /dev/null ; exit $?

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241599 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dan Liew 2015-07-07 15:50:33 +00:00
parent db38d7657a
commit 9fb4897162
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
utils/release/test-release.sh
View File

@ -348,7 +348,11 @@ function package_release() {
cd $cwd
}
set -e # Exit if any command fails
# Exit if any command fails
# Note: pipefail is necessary for running build commands through
# a pipe (i.e. it changes the output of ``false | tee /dev/null ; echo $?``)
set -e
set -o pipefail
if [ "$do_checkout" = "yes" ]; then
export_sources