RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-02-04 09:37:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Safely turn memset_chk etc. to non-chk variant if the known object size is >= memset / memcpy / memmove size.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@97828 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Evan Cheng 2010-03-05 20:59:47 +00:00
parent a862326bc7
commit a79eb387ac
2 changed files with 37 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
lib/Transforms/Scalar/SimplifyLibCalls.cpp
View File

@ -1006,10 +1006,12 @@ struct MemCpyChkOpt : public LibCallOptimization {
FT->getParamType(2) != TD->getIntPtrType(*Context))
return 0;
ConstantInt *SizeCI = dyn_cast<ConstantInt>(CI->getOperand(4));
if (!SizeCI)
ConstantInt *ObjSizeCI = dyn_cast<ConstantInt>(CI->getOperand(4));
if (!ObjSizeCI)
return 0;
if (SizeCI->isAllOnesValue()) {
ConstantInt *SizeCI = dyn_cast<ConstantInt>(CI->getOperand(3));
if (ObjSizeCI->isAllOnesValue() ||
(SizeCI && ObjSizeCI->getValue().uge(SizeCI->getValue()))) {
EmitMemCpy(CI->getOperand(1), CI->getOperand(2), CI->getOperand(3), 1, B);
return CI->getOperand(1);
}
@ -1034,10 +1036,12 @@ struct MemSetChkOpt : public LibCallOptimization {
FT->getParamType(2) != TD->getIntPtrType(*Context))
return 0;
ConstantInt *SizeCI = dyn_cast<ConstantInt>(CI->getOperand(4));
if (!SizeCI)
ConstantInt *ObjSizeCI = dyn_cast<ConstantInt>(CI->getOperand(4));
if (!ObjSizeCI)
return 0;
if (SizeCI->isAllOnesValue()) {
ConstantInt *SizeCI = dyn_cast<ConstantInt>(CI->getOperand(3));
if (ObjSizeCI->isAllOnesValue() ||
(SizeCI && ObjSizeCI->getValue().uge(SizeCI->getValue()))) {
Value *Val = B.CreateIntCast(CI->getOperand(2), Type::getInt8Ty(*Context),
false);
EmitMemSet(CI->getOperand(1), Val, CI->getOperand(3), B);
@ -1064,10 +1068,12 @@ struct MemMoveChkOpt : public LibCallOptimization {
FT->getParamType(2) != TD->getIntPtrType(*Context))
return 0;
ConstantInt *SizeCI = dyn_cast<ConstantInt>(CI->getOperand(4));
if (!SizeCI)
ConstantInt *ObjSizeCI = dyn_cast<ConstantInt>(CI->getOperand(4));
if (!ObjSizeCI)
return 0;
if (SizeCI->isAllOnesValue()) {
ConstantInt *SizeCI = dyn_cast<ConstantInt>(CI->getOperand(3));
if (ObjSizeCI->isAllOnesValue() ||
(SizeCI && ObjSizeCI->getValue().uge(SizeCI->getValue()))) {
EmitMemMove(CI->getOperand(1), CI->getOperand(2), CI->getOperand(3),
1, B);
return CI->getOperand(1);
@ -1085,8 +1091,8 @@ struct StrCpyChkOpt : public LibCallOptimization {
!FT->getParamType(1)->isPointerTy())
return 0;
ConstantInt *SizeCI = dyn_cast<ConstantInt>(CI->getOperand(3));
if (!SizeCI)
ConstantInt *ObjSizeCI = dyn_cast<ConstantInt>(CI->getOperand(3));
if (!ObjSizeCI)
return 0;
// If a) we don't have any length information, or b) we know this will
@ -1094,8 +1100,8 @@ struct StrCpyChkOpt : public LibCallOptimization {
// strcpy_chk call which may fail at runtime if the size is too long.
// TODO: It might be nice to get a maximum length out of the possible
// string lengths for varying.
if (SizeCI->isAllOnesValue() ||
SizeCI->getZExtValue() >= GetStringLength(CI->getOperand(2)))
if (ObjSizeCI->isAllOnesValue() ||
ObjSizeCI->getZExtValue() >= GetStringLength(CI->getOperand(2)))
return EmitStrCpy(CI->getOperand(1), CI->getOperand(2), B);
return 0;

18
test/Transforms/SimplifyLibCalls/memset_chk.ll Normal file
View File

@ -0,0 +1,18 @@
; RUN: opt < %s -simplify-libcalls -S | FileCheck %s
; rdar://7719085
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
%struct.data = type { [100 x i32], [100 x i32], [1024 x i8] }
define i32 @t() nounwind ssp {
; CHECK: @t
; CHECK: @llvm.memset.i64
entry:
%0 = alloca %struct.data, align 8 ; <%struct.data*> [#uses=1]
%1 = bitcast %struct.data* %0 to i8* ; <i8*> [#uses=1]
%2 = call i8* @__memset_chk(i8* %1, i32 0, i64 1824, i64 1824) nounwind ; <i8*> [#uses=0]
ret i32 0
}
declare i8* @__memset_chk(i8*, i32, i64, i64) nounwind