RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2026-07-20 19:04:10 -04:00
Code Issues Packages Projects Releases 10 Wiki Activity

[llvm-cov] Move the 'jump to first unexecuted line' link

Browse Source 
Having it in the same row as the source name is jarring. Move it next to
the "Source" column label.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@281146 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Vedant Kumar
2016-09-10 19:37:26 +00:00
parent ce19c1cc95
commit a8edd76b0e
7 changed files with 36 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/llvm-cov/SourceCoverageViewHTML.cpp
+15 -14
View File
@@ -395,21 +395,11 @@ void SourceCoverageViewHTML::renderViewFooter(raw_ostream &OS) {
OS << EndTable << EndCenteredDiv;
}
void SourceCoverageViewHTML::renderSourceName(raw_ostream &OS, bool WholeFile,
unsigned FirstUncoveredLineNo) {
void SourceCoverageViewHTML::renderSourceName(raw_ostream &OS, bool WholeFile) {
OS << BeginSourceNameDiv;
std::string ViewInfo = escape(
WholeFile ? getVerboseSourceName() : getSourceName(), getOptions());
OS << tag("pre", ViewInfo);
if (WholeFile) {
// Render the "Go to first unexecuted line" link for the view.
if (FirstUncoveredLineNo != 0) { // The file is not fully covered
std::string LinkText =
escape("Go to first unexecuted line", getOptions());
std::string LinkTarget = "#L" + utostr(uint64_t(FirstUncoveredLineNo));
OS << tag("pre", a(LinkTarget, LinkText));
}
}
OS << EndSourceNameDiv;
}
@@ -608,10 +598,21 @@ void SourceCoverageViewHTML::renderCellInTitle(raw_ostream &OS,
}
void SourceCoverageViewHTML::renderTableHeader(raw_ostream &OS,
unsigned FirstUncoveredLineNo,
unsigned ViewDepth) {
std::string SourceLabel;
if (FirstUncoveredLineNo == 0) {
SourceLabel = tag("td", tag("pre", "Source"));
} else {
std::string LinkTarget = "#L" + utostr(uint64_t(FirstUncoveredLineNo));
SourceLabel =
tag("td", tag("pre", "Source (" +
a(LinkTarget, "jump to first uncovered line") +
")"));
}
renderLinePrefix(OS, ViewDepth);
OS << tag("td", tag("span", tag("pre", escape("Line No.", getOptions()))))
<< tag("td", tag("span", tag("pre", escape("Count", getOptions()))))
<< tag("td", tag("span", tag("pre", escape("Source", getOptions()))));
OS << tag("td", tag("pre", "Line No.")) << tag("td", tag("pre", "Count"))
<< SourceLabel;
renderLineSuffix(OS, ViewDepth);
}