RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-04-02 13:21:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

X86: FrameIndex addressing modes do have a base register.

Browse Source 
When selecting the DAG (add (WrapperRIP ...), (FrameIndex ...)), X86 code had
spotted the FrameIndex possibility and was working out whether it could fold
the WrapperRIP into this.

The test for forming a %rip version is notionally whether we already have a
base or index register (%rip precludes both), but we were forgetting to account
for the register that would be inserted later to access the frame.

rdar://problem/15024520

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@190995 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Tim Northover 2013-09-19 11:33:53 +00:00
parent abe68f5917
commit adadf887cb
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Target/X86/X86ISelDAGToDAG.cpp
View File

@ -79,7 +79,8 @@ namespace {
}
bool hasBaseOrIndexReg() const {
return IndexReg.getNode() != 0 || Base_Reg.getNode() != 0;
return BaseType == FrameIndexBase ||
IndexReg.getNode() != 0 || Base_Reg.getNode() != 0;
}
/// isRIPRelative - Return true if this addressing mode is already RIP

22
test/CodeGen/X86/frame-base.ll Normal file
View File

@ -0,0 +1,22 @@
; RUN: llc -mtriple=x86_64-apple-macosx -o - %s | FileCheck %s
; The issue here was a conflict between forming a %rip-relative lea and a
; FrameIndex lea. The %rip sanity-checks didn't consider that a base register
; had been set if we'd already matched a FrameIndex, when it has in reality.
@var = global i32 0
define void @test_frame_rip_conflict() {
; CHECK-LABEL: test_frame_rip_conflict:
; CHECK: leaq _var(%rip), [[TMPADDR:%r.*]]
; CHECK: leaq {{-?[0-9]+}}(%rsp,[[TMPADDR]]),
%stackvar = alloca i32
%stackint = ptrtoint i32* %stackvar to i64
%addr = add i64 ptrtoint(i32* @var to i64), %stackint
call void @eat_i64(i64 %addr)
ret void
}
declare void @eat_i64(i64)