diff --git a/lib/VMCore/Verifier.cpp b/lib/VMCore/Verifier.cpp index 16e87f4f7a1..4e3a16e8ee9 100644 --- a/lib/VMCore/Verifier.cpp +++ b/lib/VMCore/Verifier.cpp @@ -361,6 +361,10 @@ void Verifier::visitFunction(Function &F) { if (const ParamAttrsList *Attrs = FT->getParamAttrs()) { unsigned Idx = 1; + + Assert(!Attrs->paramHasAttr(0, ParamAttr::ByVal), + "Attribute ByVal should not apply to functions!"); + for (FunctionType::param_iterator I = FT->param_begin(), E = FT->param_end(); I != E; ++I, ++Idx) { if (Attrs->paramHasAttr(Idx, ParamAttr::ZExt) || @@ -370,9 +374,14 @@ void Verifier::visitFunction(Function &F) { if (Attrs->paramHasAttr(Idx, ParamAttr::NoAlias)) Assert1(isa(FT->getParamType(Idx-1)), "Attribute NoAlias should only apply to Pointer type!", &F); - if (Attrs->paramHasAttr(Idx, ParamAttr::ByVal)) + if (Attrs->paramHasAttr(Idx, ParamAttr::ByVal)) { Assert1(isa(FT->getParamType(Idx-1)), - "Attribute ByVal should only apply to Pointer type!", &F); + "Attribute ByVal should only apply to pointer to structs!", &F); + const PointerType *Ty = + cast(FT->getParamType(Idx-1)); + Assert1(isa(Ty->getElementType()), + "Attribute ByVal should only apply to pointer to structs!", &F); + } } } diff --git a/test/Verifier/byval-1.ll b/test/Verifier/byval-1.ll new file mode 100644 index 00000000000..cbae548c974 --- /dev/null +++ b/test/Verifier/byval-1.ll @@ -0,0 +1,2 @@ +; RUN: not llvm-as < %s -o /dev/null -f +declare void @h(i32* byval %num) diff --git a/test/Verifier/byval-2.ll b/test/Verifier/byval-2.ll new file mode 100644 index 00000000000..56b8a27d1f5 --- /dev/null +++ b/test/Verifier/byval-2.ll @@ -0,0 +1,2 @@ +; RUN: not llvm-as < %s -o /dev/null -f +declare void @h(i32* %num) byval diff --git a/test/Verifier/byval-3.ll b/test/Verifier/byval-3.ll new file mode 100644 index 00000000000..9c2cb98451a --- /dev/null +++ b/test/Verifier/byval-3.ll @@ -0,0 +1,2 @@ +; RUN: not llvm-as < %s -o /dev/null -f +declare void @h(i32 byval %num) diff --git a/test/Verifier/byval-4.ll b/test/Verifier/byval-4.ll new file mode 100644 index 00000000000..ff733a5bdc9 --- /dev/null +++ b/test/Verifier/byval-4.ll @@ -0,0 +1,4 @@ +; RUN: llvm-as < %s -o /dev/null -f +%struct.foo = type { i64 } + +declare void @h(%struct.foo* byval %num)