RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2026-07-19 23:23:38 -04:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix stack-use-after free after r359580

Browse Source 
`Candidate` was a StringRef refering to a temporary string.
Instead, create a local variable for the string and use
a StringRef referring to that.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@359604 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Nico Weber
2019-04-30 19:43:35 +00:00
parent f8e418c85a
commit bb327bcc1e
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Option/OptTable.cpp
+4 -3
View File
@@ -296,10 +296,11 @@ unsigned OptTable::findNearest(StringRef Option, std::string &NearestString,
// "--help" over "-help".
for (int P = 0; const char *const CandidatePrefix = CandidateInfo.Prefixes[P]; P++) {
std::string NormalizedName = (LHS + Delimiter).str();
StringRef Candidate = (CandidatePrefix + CandidateName).str();
std::string Candidate = (CandidatePrefix + CandidateName).str();
StringRef CandidateRef = Candidate;
unsigned Distance =
Candidate.edit_distance(NormalizedName, /*AllowReplacements=*/true,
/*MaxEditDistance=*/BestDistance);
CandidateRef.edit_distance(NormalizedName, /*AllowReplacements=*/true,
/*MaxEditDistance=*/BestDistance);
if (Distance < BestDistance) {
BestDistance = Distance;
NearestString = (Candidate + RHS).str();