RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-01-10 14:12:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[LoopUnswitch] Don't remove instructions with side effects.

Browse Source 
This fixes PR32818.

Differential Revision:  https://reviews.llvm.org/D32664

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@301722 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Davide Italiano 2017-04-29 00:12:18 +00:00
parent 3d4cc16e3a
commit bbc33ba775
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Transforms/Scalar/LoopUnswitch.cpp
View File

@ -1275,7 +1275,8 @@ static void ReplaceUsesOfWith(Instruction *I, Value *V,
LPM->deleteSimpleAnalysisValue(I, L);
RemoveFromWorklist(I, Worklist);
I->replaceAllUsesWith(V);
I->eraseFromParent();
if (!I->mayHaveSideEffects())
I->eraseFromParent();
++NumSimplify;
}

19
test/Transforms/LoopUnswitch/pr32818.ll Normal file
View File

@ -0,0 +1,19 @@
; Check that the call doesn't get removed even if
; it has no uses. It could have side-effects.
; RUN: opt -loop-unswitch -S %s | FileCheck %s
; CHECK-LABEL: @tinky
define i32 @tinkywinky(i8 %patatino) {
%cmp1 = icmp slt i8 %patatino, 5
br label %body
body:
%i = select i1 %cmp1, i8 6, i8 undef
br i1 true, label %body, label %end
end:
%split = phi i8 [ %i, %body ]
%conv4 = sext i8 %split to i32
; CHECK: tail call fastcc i32 @fn5(
%call = tail call fastcc i32 @fn5(i32 %conv4)
ret i32 0
}
declare fastcc i32 @fn5(i32 returned) unnamed_addr