From d20cc14dbf6d54d896e67b9920cd9bccdc14c41a Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Tue, 23 Oct 2007 20:58:37 +0000 Subject: [PATCH] Make DomTree and PostDomTree thin wrappers around DomTreeBase, rather than inheriting from it. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43259 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Analysis/PostDominators.h | 28 +++++++++++++++++++++++--- lib/Analysis/PostDominators.cpp | 20 +----------------- lib/VMCore/Dominators.cpp | 12 +---------- 3 files changed, 27 insertions(+), 33 deletions(-) diff --git a/include/llvm/Analysis/PostDominators.h b/include/llvm/Analysis/PostDominators.h index 71b06e2877e..ca9f6b192a9 100644 --- a/include/llvm/Analysis/PostDominators.h +++ b/include/llvm/Analysis/PostDominators.h @@ -21,17 +21,39 @@ namespace llvm { /// PostDominatorTree Class - Concrete subclass of DominatorTree that is used to /// compute the a post-dominator tree. /// -struct PostDominatorTree : public DominatorTreeBase { +struct PostDominatorTree : public FunctionPass { static char ID; // Pass identification, replacement for typeid + DominatorTreeBase* DT; - PostDominatorTree() : - DominatorTreeBase((intptr_t)&ID, true) {} + PostDominatorTree() : FunctionPass((intptr_t)&ID) { + DT = new DominatorTreeBase(intptr_t(&ID), true); + } virtual bool runOnFunction(Function &F); virtual void getAnalysisUsage(AnalysisUsage &AU) const { AU.setPreservesAll(); } + + inline const std::vector &getRoots() const { + return DT->getRoots(); + } + + inline DomTreeNode *getRootNode() const { + return DT->getRootNode(); + } + + inline DomTreeNode *operator[](BasicBlock *BB) const { + return DT->getNode(BB); + } + + inline bool properlyDominates(const DomTreeNode* A, DomTreeNode* B) const { + return DT->properlyDominates(A, B); + } + + inline bool properlyDominates(BasicBlock* A, BasicBlock* B) const { + return DT->properlyDominates(A, B); + } }; diff --git a/lib/Analysis/PostDominators.cpp b/lib/Analysis/PostDominators.cpp index 0384fad732e..370cd955299 100644 --- a/lib/Analysis/PostDominators.cpp +++ b/lib/Analysis/PostDominators.cpp @@ -29,25 +29,7 @@ static RegisterPass F("postdomtree", "Post-Dominator Tree Construction", true); bool PostDominatorTree::runOnFunction(Function &F) { - reset(); // Reset from the last time we were run... - - // Initialize the roots list - for (Function::iterator I = F.begin(), E = F.end(); I != E; ++I) { - TerminatorInst *Insn = I->getTerminator(); - if (Insn->getNumSuccessors() == 0) { - // Unreachable block is not a root node. - if (!isa(Insn)) - Roots.push_back(I); - } - - // Prepopulate maps so that we don't get iterator invalidation issues later. - IDoms[I] = 0; - DomTreeNodes[I] = 0; - } - - Vertex.push_back(0); - - Calculate, GraphTraits > >(*this, F); + DT->recalculate(F); return false; } diff --git a/lib/VMCore/Dominators.cpp b/lib/VMCore/Dominators.cpp index b909a0014cd..5bb25d47d61 100644 --- a/lib/VMCore/Dominators.cpp +++ b/lib/VMCore/Dominators.cpp @@ -57,17 +57,7 @@ static RegisterPass E("domtree", "Dominator Tree Construction", true); bool DominatorTree::runOnFunction(Function &F) { - reset(); // Reset from the last time we were run... - - // Initialize roots - Roots.push_back(&F.getEntryBlock()); - IDoms[&F.getEntryBlock()] = 0; - DomTreeNodes[&F.getEntryBlock()] = 0; - Vertex.push_back(0); - - Calculate >(*this, F); - - updateDFSNumbers(); + DT->recalculate(F); return false; }