diff --git a/include/llvm/BinaryFormat/Dwarf.h b/include/llvm/BinaryFormat/Dwarf.h index b7a056b1811..ab927565d05 100644 --- a/include/llvm/BinaryFormat/Dwarf.h +++ b/include/llvm/BinaryFormat/Dwarf.h @@ -484,7 +484,7 @@ private: }; /// Constants that define the DWARF format as 32 or 64 bit. -enum DwarfFormat { DWARF32, DWARF64 }; +enum DwarfFormat : uint8_t { DWARF32, DWARF64 }; } // End of namespace dwarf diff --git a/include/llvm/DebugInfo/DWARF/DWARFFormValue.h b/include/llvm/DebugInfo/DWARF/DWARFFormValue.h index 47166311307..78fa6639db0 100644 --- a/include/llvm/DebugInfo/DWARF/DWARFFormValue.h +++ b/include/llvm/DebugInfo/DWARF/DWARFFormValue.h @@ -142,7 +142,7 @@ public: /// \returns Optional value with the fixed byte size or None if /// \p Form doesn't have a fixed byte size. static Optional getFixedByteSize(dwarf::Form Form, - const DWARFFormParams &FormParams); + const DWARFFormParams FormParams); /// Skip a form's value in \p DebugInfoData at the offset specified by /// \p OffsetPtr. @@ -154,7 +154,7 @@ public: /// \param Params DWARF parameters to help interpret forms. /// \returns true on success, false if the form was not skipped. bool skipValue(DataExtractor DebugInfoData, uint32_t *OffsetPtr, - const DWARFFormParams &Params) const { + const DWARFFormParams Params) const { return DWARFFormValue::skipValue(Form, DebugInfoData, OffsetPtr, Params); } @@ -169,7 +169,7 @@ public: /// \param FormParams DWARF parameters to help interpret forms. /// \returns true on success, false if the form was not skipped. static bool skipValue(dwarf::Form Form, DataExtractor DebugInfoData, - uint32_t *OffsetPtr, const DWARFFormParams &FormParams); + uint32_t *OffsetPtr, const DWARFFormParams FormParams); private: void dumpString(raw_ostream &OS) const; diff --git a/lib/DebugInfo/DWARF/DWARFFormValue.cpp b/lib/DebugInfo/DWARF/DWARFFormValue.cpp index dda4a0cdb31..861114bde1f 100644 --- a/lib/DebugInfo/DWARF/DWARFFormValue.cpp +++ b/lib/DebugInfo/DWARF/DWARFFormValue.cpp @@ -61,7 +61,7 @@ static const DWARFFormValue::FormClass DWARF4FormClasses[] = { Optional DWARFFormValue::getFixedByteSize(dwarf::Form Form, - const DWARFFormParams &Params) { + const DWARFFormParams Params) { switch (Form) { case DW_FORM_addr: assert(Params.Version && Params.AddrSize && "Invalid Params for form"); @@ -146,7 +146,7 @@ DWARFFormValue::getFixedByteSize(dwarf::Form Form, bool DWARFFormValue::skipValue(dwarf::Form Form, DataExtractor DebugInfoData, uint32_t *OffsetPtr, - const DWARFFormParams &Params) { + const DWARFFormParams Params) { bool Indirect = false; do { switch (Form) {