RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-01-07 04:21:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Clear kill flags on all used registers when sinking instructions.

Browse Source 
The test here was sinking the AND here to a lower BB:

	%vreg7<def> = ANDWri %vreg8, 0; GPR32common:%vreg7,%vreg8
	TBNZW %vreg8<kill>, 0, <BB#1>; GPR32common:%vreg8

which meant that vreg8 was read after it was killed.

This commit changes the code from clearing kill flags on the AND to clearing flags on all registers used by the AND.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@236886 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Pete Cooper 2015-05-08 17:54:32 +00:00
parent 8eaf047588
commit d90099d36c
2 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/CodeGen/MachineSink.cpp
View File

@ -756,7 +756,13 @@ bool MachineSinking::SinkInstruction(MachineInstr *MI, bool &SawStore) {
// Conservatively, clear any kill flags, since it's possible that they are no
// longer correct.
MI->clearKillInfo();
// Note that we have to clear the kill flags for any register this instruction
// uses as we may sink over another instruction which currently kills the
// used registers.
for (MachineOperand &MO : MI->operands()) {
if (MO.isReg() && MO.isUse())
MRI->clearKillFlags(MO.getReg());
}
return true;
}

29
test/CodeGen/AArch64/machine-sink-kill-flags.ll Normal file
View File

@ -0,0 +1,29 @@
; RUN: llc %s -o - -fast-isel=true -O1 -verify-machineinstrs | FileCheck %s
target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"
target triple = "arm64-apple-ios8.0.0"
; The machine verifier was asserting on this test because the AND instruction was
; sunk below the test which killed %tmp340.
; The kill flags on the test had to be cleared because the AND was going to read
; registers in a BB after the test instruction.
; CHECK: %bb343
; CHECK: and
define i32 @test(i32* %ptr) {
bb:
br label %.thread
.thread: ; preds = %.thread, %bb
%loc = phi i32 [ %next_iter, %.thread ], [ 0, %bb ]
%next_iter = lshr i32 %loc, 1
%tmp340 = sub i32 %loc, 1
%tmp341 = and i32 %tmp340, 1
%tmp342 = icmp eq i32 %tmp341, 0
br i1 %tmp342, label %bb343, label %.thread
bb343: ; preds = %.thread
store i32 %tmp341, i32* %ptr, align 4
ret i32 -1
}