RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2024-12-03 09:21:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

--- Reverse-merging (from foreign repository) r67049 into '.':

Browse Source 
U    test/CodeGen/X86/2009-03-13-PHIElimBug.ll
D    test/CodeGen/X86/2009-03-16-PHIElimInLPad.ll
U    lib/CodeGen/PHIElimination.cpp

r67049 was causing this failure:

Running /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.src/test/CodeGen/X86/dg.exp ...
FAIL: /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.src/test/CodeGen/X86/2009-03-13-PHIElimBug.ll for PR3784
Failed with exit(1) at line 1
while running:  llvm-as < /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.src/test/CodeGen/X86/2009-03-13-PHIElimBug.ll |  llc -march=x86 | /usr/bin/grep -A 2 {call f} | /usr/bin/grep movl
child process exited abnormally


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@67051 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Bill Wendling 2009-03-16 20:27:20 +00:00
parent dfec24c877
commit db14d63cea
3 changed files with 67 additions and 101 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

98
lib/CodeGen/PHIElimination.cpp
View File

@ -14,8 +14,6 @@
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#define DEBUG_TYPE "phielim" #define DEBUG_TYPE "phielim"
#include "llvm/BasicBlock.h"
#include "llvm/Instructions.h"
#include "llvm/CodeGen/LiveVariables.h" #include "llvm/CodeGen/LiveVariables.h"
#include "llvm/CodeGen/Passes.h" #include "llvm/CodeGen/Passes.h"
#include "llvm/CodeGen/MachineFunctionPass.h" #include "llvm/CodeGen/MachineFunctionPass.h"
@ -33,6 +31,7 @@
using namespace llvm; using namespace llvm;
STATISTIC(NumAtomic, "Number of atomic phis lowered"); STATISTIC(NumAtomic, "Number of atomic phis lowered");
STATISTIC(NumEH, "Number of EH try blocks skipped");
namespace { namespace {
class VISIBILITY_HIDDEN PNE : public MachineFunctionPass { class VISIBILITY_HIDDEN PNE : public MachineFunctionPass {
@ -67,25 +66,8 @@ namespace {
/// ///
void analyzePHINodes(const MachineFunction& Fn); void analyzePHINodes(const MachineFunction& Fn);
// FindCopyInsertPoint - Find a safe place in MBB to insert a copy from void WalkPassEHTryRange(MachineBasicBlock &MBB,
// SrcReg. This needs to be after any def or uses of SrcReg, but before MachineBasicBlock::iterator &I, unsigned SrcReg);
// any subsequent point where control flow might jump out of the basic
// block.
MachineBasicBlock::iterator FindCopyInsertPoint(MachineBasicBlock &MBB,
unsigned SrcReg);
// SkipPHIsAndLabels - Copies need to be inserted after phi nodes and
// also after any exception handling labels: in landing pads execution
// starts at the label, so any copies placed before it won't be executed!
MachineBasicBlock::iterator SkipPHIsAndLabels(MachineBasicBlock &MBB,
MachineBasicBlock::iterator I) {
// Rather than assuming that EH labels come before other kinds of labels,
// just skip all labels.
while (I != MBB.end() &&
(I->getOpcode() == TargetInstrInfo::PHI || I->isLabel()))
++I;
return I;
}
typedef std::pair<const MachineBasicBlock*, unsigned> BBVRegPair; typedef std::pair<const MachineBasicBlock*, unsigned> BBVRegPair;
typedef std::map<BBVRegPair, unsigned> VRegPHIUse; typedef std::map<BBVRegPair, unsigned> VRegPHIUse;
@ -138,7 +120,10 @@ bool PNE::EliminatePHINodes(MachineFunction &MF, MachineBasicBlock &MBB) {
// Get an iterator to the first instruction after the last PHI node (this may // Get an iterator to the first instruction after the last PHI node (this may
// also be the end of the basic block). // also be the end of the basic block).
MachineBasicBlock::iterator AfterPHIsIt = SkipPHIsAndLabels(MBB, MBB.begin()); MachineBasicBlock::iterator AfterPHIsIt = MBB.begin();
while (AfterPHIsIt != MBB.end() &&
AfterPHIsIt->getOpcode() == TargetInstrInfo::PHI)
++AfterPHIsIt; // Skip over all of the PHI nodes...
while (MBB.front().getOpcode() == TargetInstrInfo::PHI) while (MBB.front().getOpcode() == TargetInstrInfo::PHI)
LowerAtomicPHINode(MBB, AfterPHIsIt); LowerAtomicPHINode(MBB, AfterPHIsIt);
@ -159,47 +144,37 @@ static bool isSourceDefinedByImplicitDef(const MachineInstr *MPhi,
return true; return true;
} }
// FindCopyInsertPoint - Find a safe place in MBB to insert a copy from SrcReg. void PNE::WalkPassEHTryRange(MachineBasicBlock &MBB,
// This needs to be after any def or uses of SrcReg, but before any subsequent MachineBasicBlock::iterator &I, unsigned SrcReg) {
// point where control flow might jump out of the basic block. if (I == MBB.begin())
MachineBasicBlock::iterator PNE::FindCopyInsertPoint(MachineBasicBlock &MBB, return;
unsigned SrcReg) { MachineBasicBlock::iterator PI = prior(I);
// Handle the trivial case trivially. if (PI->getOpcode() != TargetInstrInfo::EH_LABEL)
if (MBB.empty()) return;
return MBB.begin();
// If this basic block does not contain an invoke, then control flow always // Trying to walk pass the EH try range. If we run into a use instruction,
// reaches the end of it, so place the copy there. The logic below works in // we want to insert the copy there.
// this case too, but is more expensive. SmallPtrSet<MachineInstr*, 4> UsesInMBB;
if (!isa<InvokeInst>(MBB.getBasicBlock()->getTerminator())) for (MachineRegisterInfo::use_iterator UI = MRI->use_begin(SrcReg),
return MBB.getFirstTerminator(); UE = MRI->use_end(); UI != UE; ++UI) {
MachineInstr *UseMI = &*UI;
// Discover any definition/uses in this basic block. if (UseMI->getParent() == &MBB)
SmallPtrSet<MachineInstr*, 8> DefUsesInMBB; UsesInMBB.insert(UseMI);
for (MachineRegisterInfo::reg_iterator RI = MRI->reg_begin(SrcReg),
RE = MRI->reg_end(); RI != RE; ++RI) {
MachineInstr *DefUseMI = &*RI;
if (DefUseMI->getParent() == &MBB)
DefUsesInMBB.insert(DefUseMI);
} }
MachineBasicBlock::iterator InsertPoint; while (PI != MBB.begin()) {
if (DefUsesInMBB.empty()) { --PI;
// No def/uses. Insert the copy at the start of the basic block. if (PI->getOpcode() == TargetInstrInfo::EH_LABEL) {
InsertPoint = MBB.begin(); ++NumEH;
} else if (DefUsesInMBB.size() == 1) { I = PI;
// Insert the copy immediately after the definition/use. return;
InsertPoint = *DefUsesInMBB.begin(); } else if (UsesInMBB.count(&*PI)) {
++InsertPoint; ++NumEH;
} else { I = next(PI);
// Insert the copy immediately after the last definition/use. return;
InsertPoint = MBB.end(); }
while (!DefUsesInMBB.count(&*--InsertPoint)) {}
++InsertPoint;
} }
return;
// Make sure the copy goes after any phi nodes however.
return SkipPHIsAndLabels(MBB, InsertPoint);
} }
/// LowerAtomicPHINode - Lower the PHI node at the top of the specified block, /// LowerAtomicPHINode - Lower the PHI node at the top of the specified block,
@ -298,7 +273,10 @@ void PNE::LowerAtomicPHINode(MachineBasicBlock &MBB,
// Find a safe location to insert the copy, this may be the first terminator // Find a safe location to insert the copy, this may be the first terminator
// in the block (or end()). // in the block (or end()).
MachineBasicBlock::iterator InsertPos = FindCopyInsertPoint(opBlock, SrcReg); MachineBasicBlock::iterator InsertPos = opBlock.getFirstTerminator();
// Walk pass EH try range if needed.
WalkPassEHTryRange(opBlock, InsertPos, SrcReg);
// Insert the copy. // Insert the copy.
TII->copyRegToReg(opBlock, InsertPos, IncomingReg, SrcReg, RC, RC); TII->copyRegToReg(opBlock, InsertPos, IncomingReg, SrcReg, RC, RC);

49
test/CodeGen/X86/2009-03-13-PHIElimBug.ll
View File

@ -1,28 +1,37 @@
; RUN: llvm-as < %s | llc -march=x86 | grep -A 2 {call f} | grep movl ; RUN: llvm-as < %s | llc -mtriple=i386-pc-linux-gnu -stats |& grep phielim | grep {Number of EH try blocks skipped} | grep 4
; Check the register copy comes after the call to f and before the call to g
; PR3784 ; PR3784
declare i32 @f() %struct.c38002a__arr___XUB = type { i32, i32 }
%struct.c38002a__arr_name = type { [0 x i32]*, %struct.c38002a__arr___XUB* }
%struct.c38002a__rec = type { i32, %struct.c38002a__arr_name }
declare i32 @g() define void @_ada_c38002a() {
define i32 @phi() {
entry: entry:
%a = call i32 @f() ; <i32> [#uses=1] %0 = invoke i8* @__gnat_malloc(i32 12)
%b = invoke i32 @g() to label %invcont unwind label %lpad ; <i8*> [#uses=0]
to label %cont unwind label %lpad ; <i32> [#uses=1]
cont: ; preds = %entry invcont: ; preds = %entry
%x = phi i32 [ %b, %entry ] ; <i32> [#uses=0] %1 = invoke i8* @__gnat_malloc(i32 20)
%aa = call i32 @g() ; <i32> [#uses=1] to label %invcont1 unwind label %lpad ; <i8*> [#uses=0]
%bb = invoke i32 @g()
to label %cont2 unwind label %lpad ; <i32> [#uses=1]
cont2: ; preds = %cont invcont1: ; preds = %invcont
%xx = phi i32 [ %bb, %cont ] ; <i32> [#uses=1] %2 = invoke i32 @report__ident_int(i32 2)
ret i32 %xx to label %.noexc unwind label %lpad ; <i32> [#uses=0]
lpad: ; preds = %cont, %entry .noexc: ; preds = %invcont1
%y = phi i32 [ %a, %entry ], [ %aa, %cont ] ; <i32> [#uses=1] %3 = invoke i32 @report__ident_int(i32 3)
ret i32 %y to label %.noexc88 unwind label %lpad ; <i32> [#uses=0]
.noexc88: ; preds = %.noexc
unreachable
lpad: ; preds = %.noexc, %invcont1, %invcont, %entry
%r.0 = phi %struct.c38002a__rec* [ null, %entry ], [ null, %invcont ], [ null, %invcont1 ], [ null, %.noexc ] ; <%struct.c38002a__rec*> [#uses=1]
%4 = getelementptr %struct.c38002a__rec* %r.0, i32 0, i32 0 ; <i32*> [#uses=1]
%5 = load i32* %4, align 4 ; <i32> [#uses=0]
ret void
} }
declare i32 @report__ident_int(i32)
declare i8* @__gnat_malloc(i32)

21
test/CodeGen/X86/2009-03-16-PHIElimInLPad.ll
View File

@ -1,21 +0,0 @@
; RUN: llvm-as < %s | llc -march=x86 | grep -A 1 lpad | grep Llabel
; Check that register copies in the landing pad come after the EH_LABEL
declare i32 @f()
define i32 @phi(i32 %x) {
entry:
%a = invoke i32 @f()
to label %cont unwind label %lpad ; <i32> [#uses=1]
cont: ; preds = %entry
%b = invoke i32 @f()
to label %cont2 unwind label %lpad ; <i32> [#uses=1]
cont2: ; preds = %cont
ret i32 %b
lpad: ; preds = %cont, %entry
%v = phi i32 [ %x, %entry ], [ %a, %cont ] ; <i32> [#uses=1]
ret i32 %v
}