RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2024-12-15 07:59:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[ScalarEvolutionExpander] Reuse findExistingExpansion during expansion cost calculation for division

Browse Source 
Primary purpose of this change is to reuse existing code inside findExistingExpansion. However it introduces very slight semantic change - findExistingExpansion now looks into exiting blocks instead of a loop latches. Originally heuristic was based on the fact that we want to look at the loop exit conditions. And since all exiting latches will be listed in the ExitingBlocks, heuristic stays roughly the same.

Differential Revision: http://reviews.llvm.org/D12008



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@245227 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Igor Laevsky 2015-08-17 16:37:04 +00:00
parent 1127a30ffe
commit dcf748827b
1 changed files with 11 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
lib/Analysis/ScalarEvolutionExpander.cpp
View File

@ -1815,11 +1815,11 @@ Value *SCEVExpander::findExistingExpansion(const SCEV *S,
const Instruction *At, Loop *L) {
using namespace llvm::PatternMatch;
SmallVector<BasicBlock *, 4> Latches;
L->getLoopLatches(Latches);
SmallVector<BasicBlock *, 4> ExitingBlocks;
L->getExitingBlocks(ExitingBlocks);
// Look for suitable value in simple conditions at the loop latches.
for (BasicBlock *BB : Latches) {
// Look for suitable value in simple conditions at the loop exits.
for (BasicBlock *BB : ExitingBlocks) {
ICmpInst::Predicate Pred;
Instruction *LHS, *RHS;
BasicBlock *TrueBB, *FalseBB;
@ -1892,22 +1892,14 @@ bool SCEVExpander::isHighCostExpansionHelper(
if (!ExitingBB)
return true;
BranchInst *ExitingBI = dyn_cast<BranchInst>(ExitingBB->getTerminator());
if (!ExitingBI || !ExitingBI->isConditional())
// At the beginning of this function we already tried to find existing value
// for plain 'S'. Now try to lookup 'S + 1' since it is common pattern
// involving division. This is just a simple search heuristic.
if (!At)
At = &ExitingBB->back();
if (!findExistingExpansion(
SE.getAddExpr(S, SE.getConstant(S->getType(), 1)), At, L))
return true;
ICmpInst *OrigCond = dyn_cast<ICmpInst>(ExitingBI->getCondition());
if (!OrigCond)
return true;
const SCEV *RHS = SE.getSCEV(OrigCond->getOperand(1));
RHS = SE.getMinusSCEV(RHS, SE.getConstant(RHS->getType(), 1));
if (RHS != S) {
const SCEV *LHS = SE.getSCEV(OrigCond->getOperand(0));
LHS = SE.getMinusSCEV(LHS, SE.getConstant(LHS->getType(), 1));
if (LHS != S)
return true;
}
}
// HowManyLessThans uses a Max expression whenever the loop is not guarded by