RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-05-13 17:06:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[opt-viewer] Remove positional arg checks (NFC)

Browse Source 
Summary:
opt-stats.py and opt-viewer.py's argument parsers both take a positional
argument 'yaml_files'. Positional arguments in Python's argparse module are
required by default, so the subsequent checks for `len(args.yaml_files) == 0`
are unnecessary -- if the length was zero, then the call to
`parser.parse_args()` would have thrown an error already.

Because there is no way for `len(args.yaml_files)` to be zero at these
points, removing the code is NFC.

Reviewers: anemet, davidxl

Reviewed By: anemet

Subscribers: llvm-commits, fhahn

Differential Revision: https://reviews.llvm.org/D34567

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@306147 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Brian Gesiak 2017-06-23 20:06:34 +00:00
parent 87f3ec22f7
commit ddb4efa8b2
2 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
utils/opt-viewer/opt-stats.py
View File

@ -24,10 +24,6 @@ if __name__ == '__main__':
help='Max job count (defaults to %(default)s, the current CPU count)') help='Max job count (defaults to %(default)s, the current CPU count)')
args = parser.parse_args() args = parser.parse_args()
if len(args.yaml_files) == 0:
parser.print_help()
sys.exit(1)
if args.jobs == 1: if args.jobs == 1:
pmap = map pmap = map
else: else:

4
utils/opt-viewer/opt-viewer.py
View File

@ -216,10 +216,6 @@ if __name__ == '__main__':
help='set source directory') help='set source directory')
args = parser.parse_args() args = parser.parse_args()
if len(args.yaml_files) == 0:
parser.print_help()
sys.exit(1)
if args.jobs == 1: if args.jobs == 1:
pmap = map pmap = map
else: else: