diff --git a/lib/Analysis/InstructionSimplify.cpp b/lib/Analysis/InstructionSimplify.cpp index 398ac52c39c..0969e7a056a 100644 --- a/lib/Analysis/InstructionSimplify.cpp +++ b/lib/Analysis/InstructionSimplify.cpp @@ -4380,13 +4380,13 @@ Value *llvm::SimplifyInstruction(Instruction *I, const DataLayout &DL, // In general, it is possible for computeKnownBits to determine all bits in a // value even when the operands are not all constants. - if (!Result && I->getType()->isIntegerTy()) { + if (!Result && I->getType()->isIntOrIntVectorTy()) { unsigned BitWidth = I->getType()->getScalarSizeInBits(); APInt KnownZero(BitWidth, 0); APInt KnownOne(BitWidth, 0); computeKnownBits(I, KnownZero, KnownOne, DL, /*Depth*/0, AC, I, DT); if ((KnownZero | KnownOne).isAllOnesValue()) - Result = ConstantInt::get(I->getContext(), KnownOne); + Result = ConstantInt::get(I->getType(), KnownOne); } /// If called on unreachable code, the above logic may report that the diff --git a/lib/Transforms/InstCombine/InstCombineShifts.cpp b/lib/Transforms/InstCombine/InstCombineShifts.cpp index 5181d233d06..95f06f2081d 100644 --- a/lib/Transforms/InstCombine/InstCombineShifts.cpp +++ b/lib/Transforms/InstCombine/InstCombineShifts.cpp @@ -580,13 +580,13 @@ Instruction *InstCombiner::FoldShiftByConstant(Value *Op0, Constant *Op1, // Check for (X << c1) << c2 and (X >> c1) >> c2 if (I.getOpcode() == ShiftOp->getOpcode()) { - uint32_t AmtSum = ShiftAmt1+ShiftAmt2; // Fold into one big shift. - // If this is oversized composite shift, then unsigned shifts get 0, ashr - // saturates. + uint32_t AmtSum = ShiftAmt1 + ShiftAmt2; // Fold into one big shift. + // If this is an oversized composite shift, then unsigned shifts become + // zero (handled in InstSimplify) and ashr saturates. if (AmtSum >= TypeBits) { if (I.getOpcode() != Instruction::AShr) - return replaceInstUsesWith(I, Constant::getNullValue(I.getType())); - AmtSum = TypeBits-1; // Saturate to 31 for i32 ashr. + return nullptr; + AmtSum = TypeBits - 1; // Saturate to 31 for i32 ashr. } return BinaryOperator::Create(I.getOpcode(), X, diff --git a/test/Analysis/ValueTracking/knownzero-shift.ll b/test/Analysis/ValueTracking/knownzero-shift.ll index cf5c0a05f21..4ceb822afa1 100644 --- a/test/Analysis/ValueTracking/knownzero-shift.ll +++ b/test/Analysis/ValueTracking/knownzero-shift.ll @@ -24,13 +24,9 @@ define i32 @shl_shl(i32 %A) { ret i32 %C } -; FIXME - define <2 x i33> @shl_shl_splat_vec(<2 x i33> %A) { ; CHECK-LABEL: @shl_shl_splat_vec( -; CHECK-NEXT: [[B:%.*]] = shl <2 x i33> %A, -; CHECK-NEXT: [[C:%.*]] = shl <2 x i33> [[B]], -; CHECK-NEXT: ret <2 x i33> [[C]] +; CHECK-NEXT: ret <2 x i33> zeroinitializer ; %B = shl <2 x i33> %A, %C = shl <2 x i33> %B, @@ -59,26 +55,18 @@ define i232 @lshr_lshr(i232 %A) { ret i232 %C } -; FIXME - define <2 x i32> @lshr_lshr_splat_vec(<2 x i32> %A) { ; CHECK-LABEL: @lshr_lshr_splat_vec( -; CHECK-NEXT: [[B:%.*]] = lshr <2 x i32> %A, -; CHECK-NEXT: [[C:%.*]] = lshr <2 x i32> [[B]], -; CHECK-NEXT: ret <2 x i32> [[C]] +; CHECK-NEXT: ret <2 x i32> zeroinitializer ; %B = lshr <2 x i32> %A, %C = lshr <2 x i32> %B, ret <2 x i32> %C } -; FIXME - define <2 x i32> @lshr_lshr_vec(<2 x i32> %A) { ; CHECK-LABEL: @lshr_lshr_vec( -; CHECK-NEXT: [[B:%.*]] = lshr <2 x i32> %A, -; CHECK-NEXT: [[C:%.*]] = lshr <2 x i32> [[B]], -; CHECK-NEXT: ret <2 x i32> [[C]] +; CHECK-NEXT: ret <2 x i32> zeroinitializer ; %B = lshr <2 x i32> %A, %C = lshr <2 x i32> %B,