RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-01-22 18:35:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make the MC symbol printer and llvm::Mangler exactly agree on mangling

Browse Source 
for systems that don't support quoting (PR4966).


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@81682 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2009-09-13 18:04:46 +00:00
parent f6dd026fed
commit e19f978323
2 changed files with 51 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

70
lib/MC/MCSymbol.cpp
View File

@ -16,16 +16,27 @@ using namespace llvm;
const MCSection *MCSymbol::AbsolutePseudoSection =
reinterpret_cast<const MCSection *>(1);
/// ShouldQuoteIdentifier - Return true if the identifier \arg Str needs quotes
/// for this assembler.
static bool ShouldQuoteIdentifier(const StringRef &Str, const MCAsmInfo &MAI) {
// If the assembler doesn't support quotes, never use them.
if (!MAI.doesAllowQuotesInName())
static bool isAcceptableChar(char C) {
if ((C < 'a' || C > 'z') &&
(C < 'A' || C > 'Z') &&
(C < '0' || C > '9') &&
C != '_' && C != '$' && C != '.' && C != '@')
return false;
// If empty, we need quotes.
if (Str.empty())
return true;
return true;
}
static char HexDigit(int V) {
return V < 10 ? V+'0' : V+'A'-10;
}
static void MangleLetter(raw_ostream &OS, unsigned char C) {
OS << '_' << HexDigit(C >> 4) << HexDigit(C & 15) << '_';
}
/// NameNeedsEscaping - Return true if the identifier \arg Str needs quotes
/// for this assembler.
static bool NameNeedsEscaping(const StringRef &Str, const MCAsmInfo &MAI) {
assert(!Str.empty() && "Cannot create an empty MCSymbol");
// If the first character is a number, we need quotes.
if (Str[0] >= '0' && Str[0] <= '9')
@ -33,23 +44,42 @@ static bool ShouldQuoteIdentifier(const StringRef &Str, const MCAsmInfo &MAI) {
// If any of the characters in the string is an unacceptable character, force
// quotes.
for (unsigned i = 0, e = Str.size(); i != e; ++i) {
char C = Str[i];
if ((C < 'a' || C > 'z') &&
(C < 'A' || C > 'Z') &&
(C < '0' || C > '9') &&
C != '_' && C != '$' && C != '.' && C != '@')
for (unsigned i = 0, e = Str.size(); i != e; ++i)
if (!isAcceptableChar(Str[i]))
return true;
}
return false;
}
static void PrintMangledName(raw_ostream &OS, StringRef Str) {
// The first character is not allowed to be a number.
if (Str[0] >= '0' && Str[0] <= '9') {
MangleLetter(OS, Str[0]);
Str = Str.substr(1);
}
for (unsigned i = 0, e = Str.size(); i != e; ++i) {
if (!isAcceptableChar(Str[i]))
MangleLetter(OS, Str[i]);
else
OS << Str[i];
}
}
void MCSymbol::print(raw_ostream &OS, const MCAsmInfo *MAI) const {
if (!MAI || ShouldQuoteIdentifier(getName(), *MAI))
OS << '"' << getName() << '"';
else
if (MAI == 0 || !NameNeedsEscaping(getName(), *MAI)) {
OS << getName();
return;
}
// On darwin and other systems that allow quoted names, just do that.
if (MAI->doesAllowQuotesInName()) {
OS << '"' << getName() << '"';
return;
}
// Otherwise, we have to mangle the name.
PrintMangledName(OS, getName());
}
void MCSymbol::dump() const {

1
lib/VMCore/Mangler.cpp
View File

@ -222,4 +222,5 @@ Mangler::Mangler(Module &M, const char *prefix, const char *privatePrefix,
markCharAcceptable('_');
markCharAcceptable('$');
markCharAcceptable('.');
markCharAcceptable('@');
}