From e268a40b1e4653a4baa8f626f976954830b840cd Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 3 Dec 2007 19:00:47 +0000 Subject: [PATCH] Describe the notion of 'owners' of the code. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@44537 91177308-0d34-0410-b5e6-96231b3b80d8 --- docs/DeveloperPolicy.html | 45 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/docs/DeveloperPolicy.html b/docs/DeveloperPolicy.html index 647e2b895f5..883509b4ffe 100644 --- a/docs/DeveloperPolicy.html +++ b/docs/DeveloperPolicy.html @@ -15,6 +15,7 @@
  • Stay Informed
  • Making a Patch
  • Code Reviews
  • +
  • Code Owners
  • Test Cases
  • Quality
  • Obtaining Commit Access
  • @@ -145,6 +146,50 @@ + +
    Code Owners
    +
    + +

    The LLVM Project relies on two features of its process to maintain rapid + development in addition to the high quality of its source base: the + combination of code review plus post-commit review for trusted maintainers. + Having both is a great way for the project to take advantage of the fact + that most people do the right thing most of the time, and only commit + patches without pre-commit review when they are confident they are + right.

    + +

    The trick to this is that the project has to guarantee that all patches + that are committed are reviewed after they go in: you don't want everyone + to assume someone else will review it, allowing the patch to go unreviewed. + To solve this problem, we have a notion of an 'owner' for a piece of the + code. The sole responsibility of a code owner is to ensure that a commit + to their area of the code is appropriately reviewed, either by themself or + by someone else. The current code owners are:

    + +
      +
    1. Anton Korobeynikov: Exception handling, debug information, and + Windows codegen.
    2. +
    3. Duncan Sands: llvm-gcc 4.2.
    4. +
    5. Evan Cheng: Code generator and all targets.
    6. +
    7. Chris Lattner: Everything else.
    8. +
    + +

    Note that code ownership is completely different than reviewers: anyone can + review a piece of code, and we welcome code review from anyone who is + interested. Code owners are the "last line of defense" to guarantee that + all patches that are committed are actually reviewed.

    + +

    Being a code owner is a somewhat unglamorous position, but it is incredibly + important for the ongoing success of the project. Because people get busy, + interests change, and unexpected things happen, code ownership is purely + opt-in, and anyone can choose to resign their "title" at any time. For now, + we do not have an official policy on how one gets elected to be a code + owner. +

    + +
    + +
    Test Cases