RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-02-05 01:56:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[InlineCost] Simplify more 'and' and 'or' operations.

Browse Source 
Differential Revision: https://reviews.llvm.org/D35856

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@309817 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chad Rosier 2017-08-02 14:40:42 +00:00
parent 340067cec4
commit e279499faf
2 changed files with 124 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
lib/Analysis/InlineCost.cpp
View File

@ -207,6 +207,8 @@ class CallAnalyzer : public InstVisitor<CallAnalyzer, bool> {
bool visitCastInst(CastInst &I);
bool visitUnaryInstruction(UnaryInstruction &I);
bool visitCmpInst(CmpInst &I);
bool visitAnd(BinaryOperator &I);
bool visitOr(BinaryOperator &I);
bool visitSub(BinaryOperator &I);
bool visitBinaryOperator(BinaryOperator &I);
bool visitLoad(LoadInst &I);
@ -843,6 +845,34 @@ bool CallAnalyzer::visitCmpInst(CmpInst &I) {
return false;
}
bool CallAnalyzer::visitOr(BinaryOperator &I) {
// This is necessary because the generic simplify instruction only works if
// both operands are constants.
for (unsigned i = 0; i < 2; ++i) {
if (ConstantInt *C = dyn_cast_or_null<ConstantInt>(
SimplifiedValues.lookup(I.getOperand(i))))
if (C->isAllOnesValue()) {
SimplifiedValues[&I] = C;
return true;
}
}
return Base::visitOr(I);
}
bool CallAnalyzer::visitAnd(BinaryOperator &I) {
// This is necessary because the generic simplify instruction only works if
// both operands are constants.
for (unsigned i = 0; i < 2; ++i) {
if (ConstantInt *C = dyn_cast_or_null<ConstantInt>(
SimplifiedValues.lookup(I.getOperand(i))))
if (C->isZero()) {
SimplifiedValues[&I] = C;
return true;
}
}
return Base::visitAnd(I);
}
bool CallAnalyzer::visitSub(BinaryOperator &I) {
// Try to handle a special case: we can fold computing the difference of two
// constant-related pointers.

94
test/Transforms/Inline/AArch64/logical-and-or.ll Normal file
View File

@ -0,0 +1,94 @@
; REQUIRES: asserts
; RUN: opt -inline -mtriple=aarch64--linux-gnu -S -debug-only=inline-cost < %s 2>&1 | FileCheck %s
target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
target triple = "aarch64--linux-gnu"
; FIXME: Once the 'or' or 'and' is simplified the second compare is dead, but
; the inline cost model has already added the cost.
define i1 @outer1(i32 %a) {
%C = call i1 @inner1(i32 0, i32 %a)
ret i1 %C
}
; CHECK: Analyzing call of inner1
; CHECK: NumInstructionsSimplified: 3
; CHECK: NumInstructions: 4
define i1 @inner1(i32 %a, i32 %b) {
%tobool = icmp eq i32 %a, 0 ; Simplifies to true
%tobool1 = icmp eq i32 %b, 0 ; Should be dead once 'or' is simplified
%or.cond = or i1 %tobool, %tobool1 ; Simplifies to true
ret i1 %or.cond ; Simplifies to ret i1 true
}
define i1 @outer2(i32 %a) {
%C = call i1 @inner2(i32 1, i32 %a)
ret i1 %C
}
; CHECK: Analyzing call of inner2
; CHECK: NumInstructionsSimplified: 3
; CHECK: NumInstructions: 4
define i1 @inner2(i32 %a, i32 %b) {
%tobool = icmp eq i32 %a, 0 ; Simplifies to false
%tobool1 = icmp eq i32 %b, 0 ; Should be dead once 'and' is simplified
%and.cond = and i1 %tobool, %tobool1 ; Simplifies to false
ret i1 %and.cond ; Simplifies to ret i1 false
}
define i32 @outer3(i32 %a) {
%C = call i32 @inner3(i32 4294967295, i32 %a)
ret i32 %C
}
; CHECK: Analyzing call of inner3
; CHECK: NumInstructionsSimplified: 2
; CHECK: NumInstructions: 2
define i32 @inner3(i32 %a, i32 %b) {
%or.cond = or i32 %a, %b ; Simplifies to 4294967295
ret i32 %or.cond ; Simplifies to ret i32 4294967295
}
define i32 @outer4(i32 %a) {
%C = call i32 @inner4(i32 0, i32 %a)
ret i32 %C
}
; CHECK: Analyzing call of inner4
; CHECK: NumInstructionsSimplified: 2
; CHECK: NumInstructions: 2
define i32 @inner4(i32 %a, i32 %b) {
%and.cond = and i32 %a, %b ; Simplifies to 0
ret i32 %and.cond ; Simplifies to ret i32 0
}
define i1 @outer5(i32 %a) {
%C = call i1 @inner5(i32 0, i32 %a)
ret i1 %C
}
; CHECK: Analyzing call of inner5
; CHECK: NumInstructionsSimplified: 4
; CHECK: NumInstructions: 5
define i1 @inner5(i32 %a, i32 %b) {
%tobool = icmp eq i32 %a, 0 ; Simplifies to true
%tobool1 = icmp eq i32 %b, 0 ; Should be dead once 'or' is simplified
%or.cond = or i1 %tobool, %tobool1 ; Simplifies to true
br i1 %or.cond, label %end, label %isfalse ; Simplifies to br label %end
isfalse: ; This block is unreachable once inlined
call void @dead()
call void @dead()
call void @dead()
call void @dead()
call void @dead()
br label %end
end:
ret i1 %or.cond ; Simplifies to ret i1 true
}
declare void @dead()