RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-01-20 00:43:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix PR1657

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@42075 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Devang Patel 2007-09-18 01:54:42 +00:00
parent 6e19896999
commit e3bfb88898
2 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/Transforms/Scalar/LICM.cpp
View File

@ -791,6 +791,14 @@ void LICM::FindPromotableValuesInLoop(
break;
}
// If GEP base is NULL then the calculated address used by Store or
// Load instruction is invalid. Do not promote this value because
// it may expose load and store instruction that are covered by
// condition which may not yet folded.
if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(V))
if (isa<ConstantPointerNull>(GEP->getOperand(0)))
PointerOk = false;
if (PointerOk) {
const Type *Ty = cast<PointerType>(V->getType())->getElementType();
AllocaInst *AI = new AllocaInst(Ty, 0, V->getName()+".tmp", FnStart);

26
test/Transforms/LICM/2007-09-17-PrompteValue.ll Normal file
View File

@ -0,0 +1,26 @@
; ModuleID = 'PR1657.bc'
; Do not promote getelementptr because it may exposes load from a null pointer
; and store from a null pointer which are covered by
; icmp eq %struct.decision* null, null condition.
; RUN: llvm-as < %s | opt -licm | llvm-dis | not grep promoted
%struct.decision = type { i8, %struct.decision* }
define i32 @main() {
entry:
br label %blah.i
blah.i: ; preds = %cond_true.i, %entry
%tmp3.i = icmp eq %struct.decision* null, null ; <i1> [#uses=1]
br i1 %tmp3.i, label %clear_modes.exit, label %cond_true.i
cond_true.i: ; preds = %blah.i
%tmp1.i = getelementptr %struct.decision* null, i32 0, i32 0 ; <i8*> [#uses=1]
store i8 0, i8* %tmp1.i
br label %blah.i
clear_modes.exit: ; preds = %blah.i
call void @exit( i32 0 )
unreachable
}
declare void @exit(i32)