From ed8c969d30e67daa180e97662dd8e9ca92a1818b Mon Sep 17 00:00:00 2001 From: Alex Lorenz Date: Mon, 17 Aug 2015 22:06:40 +0000 Subject: [PATCH] MIR Serialization: Serialize the memory operand's alias scope metadata node. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@245245 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/MIRParser/MILexer.cpp | 1 + lib/CodeGen/MIRParser/MILexer.h | 1 + lib/CodeGen/MIRParser/MIParser.cpp | 8 ++++-- lib/CodeGen/MIRPrinter.cpp | 5 +++- test/CodeGen/MIR/X86/memory-operands.mir | 33 ++++++++++++++++++++++++ 5 files changed, 45 insertions(+), 3 deletions(-) diff --git a/lib/CodeGen/MIRParser/MILexer.cpp b/lib/CodeGen/MIRParser/MILexer.cpp index f4c9786d421..4ebe7cd4371 100644 --- a/lib/CodeGen/MIRParser/MILexer.cpp +++ b/lib/CodeGen/MIRParser/MILexer.cpp @@ -445,6 +445,7 @@ static Cursor maybeLexNumericalLiteral(Cursor C, MIToken &Token) { static MIToken::TokenKind getMetadataKeywordKind(StringRef Identifier) { return StringSwitch(Identifier) .Case("!tbaa", MIToken::md_tbaa) + .Case("!alias.scope", MIToken::md_alias_scope) .Default(MIToken::Error); } diff --git a/lib/CodeGen/MIRParser/MILexer.h b/lib/CodeGen/MIRParser/MILexer.h index fc92cc14e89..33748209e93 100644 --- a/lib/CodeGen/MIRParser/MILexer.h +++ b/lib/CodeGen/MIRParser/MILexer.h @@ -87,6 +87,7 @@ struct MIToken { // Named metadata keywords md_tbaa, + md_alias_scope, // Identifier tokens Identifier, diff --git a/lib/CodeGen/MIRParser/MIParser.cpp b/lib/CodeGen/MIRParser/MIParser.cpp index e076a2d5b5e..271f7f08227 100644 --- a/lib/CodeGen/MIRParser/MIParser.cpp +++ b/lib/CodeGen/MIRParser/MIParser.cpp @@ -1538,12 +1538,16 @@ bool MIParser::parseMachineMemoryOperand(MachineMemOperand *&Dest) { if (parseMDNode(AAInfo.TBAA)) return true; break; - // TODO: Parse AA Scope metadata. + case MIToken::md_alias_scope: + lex(); + if (parseMDNode(AAInfo.Scope)) + return true; + break; // TODO: Parse AA NoAlias metadata. // TODO: Parse the ranges metadata. // TODO: Report an error on duplicate metadata nodes. default: - return error("expected 'align' or '!tbaa'"); + return error("expected 'align' or '!tbaa' or '!alias.scope'"); } } if (expectAndConsume(MIToken::rparen)) diff --git a/lib/CodeGen/MIRPrinter.cpp b/lib/CodeGen/MIRPrinter.cpp index b7292f3e151..6be8205f65e 100644 --- a/lib/CodeGen/MIRPrinter.cpp +++ b/lib/CodeGen/MIRPrinter.cpp @@ -782,7 +782,10 @@ void MIPrinter::print(const MachineMemOperand &Op) { OS << ", !tbaa "; AAInfo.TBAA->printAsOperand(OS, MST); } - // TODO: Print AA Scope metadata. + if (AAInfo.Scope) { + OS << ", !alias.scope "; + AAInfo.Scope->printAsOperand(OS, MST); + } // TODO: Print AA NoAlias metadata. // TODO: Print the ranges metadata. OS << ')'; diff --git a/test/CodeGen/MIR/X86/memory-operands.mir b/test/CodeGen/MIR/X86/memory-operands.mir index 0a3f13a9ab8..4a97cd8caa5 100644 --- a/test/CodeGen/MIR/X86/memory-operands.mir +++ b/test/CodeGen/MIR/X86/memory-operands.mir @@ -132,6 +132,22 @@ !7 = !{!"XXH_state64_t", !3, i64 0, !3, i64 4, !8, i64 8, !8, i64 16, !8, i64 24} !8 = !{!"long long", !4, i64 0} + define void @aa_scope(float* nocapture %a, float* nocapture readonly %c) #1 { + entry: + %0 = load float, float* %c, align 4, !alias.scope !9 + %arrayidx.i = getelementptr inbounds float, float* %a, i64 5 + store float %0, float* %arrayidx.i, align 4, !noalias !9 + %1 = load float, float* %c, align 4 + %arrayidx = getelementptr inbounds float, float* %a, i64 7 + store float %1, float* %arrayidx, align 4 + ret void + } + + attributes #1 = { nounwind uwtable } + + !9 = distinct !{!9, !10, !"some scope"} + !10 = distinct !{!10, !"some domain"} + ... --- name: test @@ -372,3 +388,20 @@ body: | %eax = MOV32rm killed %rax, 1, _, 0, _ :: (load 4 from %ir.total_len2, !tbaa !6) RETQ %eax ... +--- +name: aa_scope +tracksRegLiveness: true +liveins: + - { reg: '%rdi' } + - { reg: '%rsi' } +body: | + bb.0.entry: + liveins: %rdi, %rsi + ; CHECK-LABEL: name: aa_scope + ; CHECK: %xmm0 = MOVSSrm %rsi, 1, _, 0, _ :: (load 4 from %ir.c, !alias.scope !9) + %xmm0 = MOVSSrm %rsi, 1, _, 0, _ :: (load 4 from %ir.c, !alias.scope !9) + MOVSSmr %rdi, 1, _, 20, _, killed %xmm0 :: (store 4 into %ir.arrayidx.i) + %xmm0 = MOVSSrm killed %rsi, 1, _, 0, _ :: (load 4 from %ir.c) + MOVSSmr killed %rdi, 1, _, 28, _, killed %xmm0 :: (store 4 into %ir.arrayidx) + RETQ +...