RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-01-29 14:42:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Constant::IsThreadDependent(): Use dyn_cast<Constant> instead of cast

Browse Source 
It turns out that the operands of a Constant are not always themselves
Constant. For example, one of the operands of BlockAddress is
BasicBlock, which is not a Constant.

This should fix the dragonegg-x86_64-linux-gcc-4.6-test build which
broke in r168037.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@168147 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Hans Wennborg 2012-11-16 10:33:25 +00:00
parent 63a450a313
commit fbeb956876
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/VMCore/Constants.cpp
View File

@ -261,7 +261,9 @@ bool Constant::isThreadDependent() const {
}
for (unsigned I = 0, E = C->getNumOperands(); I != E; ++I) {
const Constant *D = cast<Constant>(C->getOperand(I));
const Constant *D = dyn_cast<Constant>(C->getOperand(I));
if (!D)
continue;
if (Visited.insert(D))
WorkList.push_back(D);
}

20
test/Transforms/GlobalOpt/blockaddress.ll Normal file
View File

@ -0,0 +1,20 @@
; RUN: opt < %s -globalopt -S | FileCheck %s
@x = internal global i8* zeroinitializer
define void @f() {
; CHECK: @f
; Check that we don't hit an assert in Constant::IsThreadDependent()
; when storing this blockaddress into a global.
store i8* blockaddress(@g, %here), i8** @x, align 8
ret void
}
define void @g() {
; CHECK: @g
here:
ret void
}