diff --git a/lib/VMCore/ConstantFold.cpp b/lib/VMCore/ConstantFold.cpp index 57b6a4e05d1..5167c12d49b 100644 --- a/lib/VMCore/ConstantFold.cpp +++ b/lib/VMCore/ConstantFold.cpp @@ -1348,43 +1348,43 @@ Constant *llvm::ConstantFoldCompareInstruction(unsigned short pred, return ConstantInt::get(Type::Int1Ty, R==APFloat::cmpGreaterThan || R==APFloat::cmpEqual); } - } else if (const ConstantVector *CP1 = dyn_cast(C1)) { - if (const ConstantVector *CP2 = dyn_cast(C2)) { - // If we can constant fold the comparison of each element, constant fold - // the whole vector comparison. - SmallVector Elts; - const Type *InEltTy = CP1->getOperand(0)->getType(); - bool isFP = InEltTy->isFloatingPoint(); - const Type *ResEltTy = InEltTy; + } else if (isa(C1->getType())) { + SmallVector C1Elts, C2Elts; + C1->getVectorElements(C1Elts); + C2->getVectorElements(C2Elts); + + // If we can constant fold the comparison of each element, constant fold + // the whole vector comparison. + SmallVector ResElts; + const Type *InEltTy = C1Elts[0]->getType(); + bool isFP = InEltTy->isFloatingPoint(); + const Type *ResEltTy = InEltTy; + if (isFP) + ResEltTy = IntegerType::get(InEltTy->getPrimitiveSizeInBits()); + + for (unsigned i = 0, e = C1Elts.size(); i != e; ++i) { + // Compare the elements, producing an i1 result or constant expr. + Constant *C; if (isFP) - ResEltTy = IntegerType::get(InEltTy->getPrimitiveSizeInBits()); - - for (unsigned i = 0, e = CP1->getNumOperands(); i != e; ++i) { - // Compare the elements, producing an i1 result or constant expr. - Constant *C; - if (isFP) - C = ConstantExpr::getFCmp(pred, CP1->getOperand(i), - CP2->getOperand(i)); - else - C = ConstantExpr::getICmp(pred, CP1->getOperand(i), - CP2->getOperand(i)); + C = ConstantExpr::getFCmp(pred, C1Elts[i], C2Elts[i]); + else + C = ConstantExpr::getICmp(pred, C1Elts[i], C2Elts[i]); - // If it is a bool or undef result, convert to the dest type. - if (ConstantInt *CI = dyn_cast(C)) { - if (CI->isZero()) - Elts.push_back(Constant::getNullValue(ResEltTy)); - else - Elts.push_back(Constant::getAllOnesValue(ResEltTy)); - } else if (isa(C)) { - Elts.push_back(UndefValue::get(ResEltTy)); - } else { - break; - } + // If it is a bool or undef result, convert to the dest type. + if (ConstantInt *CI = dyn_cast(C)) { + if (CI->isZero()) + ResElts.push_back(Constant::getNullValue(ResEltTy)); + else + ResElts.push_back(Constant::getAllOnesValue(ResEltTy)); + } else if (isa(C)) { + ResElts.push_back(UndefValue::get(ResEltTy)); + } else { + break; } - - if (Elts.size() == CP1->getNumOperands()) - return ConstantVector::get(&Elts[0], Elts.size()); } + + if (ResElts.size() == C1Elts.size()) + return ConstantVector::get(&ResElts[0], ResElts.size()); } if (C1->getType()->isFloatingPoint()) { diff --git a/test/Transforms/ConstProp/2008-07-07-VectorCompare.ll b/test/Transforms/ConstProp/2008-07-07-VectorCompare.ll index b42b0248496..4c714632048 100644 --- a/test/Transforms/ConstProp/2008-07-07-VectorCompare.ll +++ b/test/Transforms/ConstProp/2008-07-07-VectorCompare.ll @@ -20,3 +20,9 @@ undef>, ret <4 x i32> %foo } +define <4 x i32> @test4() { + %foo = vfcmp ueq <4 x float> , + + ret <4 x i32> %foo +} +