mirror of
https://github.com/RPCS3/llvm.git
synced 2025-05-15 18:06:08 +00:00
845b439bb4
Summary: GCC and the binutils COFF linker do comdats differently from MSVC. If we want to be ABI compatible, we have to do what they do, which is to emit unique section names like ".text$_Z3foov" instead of short section names like ".text". Otherwise, the binutils linker gets confused and reports multiple definition errors when two object files from GCC and Clang containing the same inline function are linked together. The best description of the issue is probably at https://github.com/Alexpux/MINGW-packages/issues/1677, we don't seem to have a good one in our tracker. I fixed up the .pdata and .xdata sections needed everywhere other than 32-bit x86. GCC doesn't use associative comdats for those, it appears to rely on the section name. Reviewers: smeenai, compnerd, mstorsjo, martell, mati865 Subscribers: llvm-commits, hiraditya Differential Revision: https://reviews.llvm.org/D48402 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@335286 91177308-0d34-0410-b5e6-96231b3b80d8
62 lines
1.9 KiB
C++
62 lines
1.9 KiB
C++
//===- MCAsmInfoCOFF.cpp - COFF asm properties ----------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines target asm properties related what form asm statements
|
|
// should take in general on COFF-based targets
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/MC/MCAsmInfoCOFF.h"
|
|
#include "llvm/MC/MCDirectives.h"
|
|
|
|
using namespace llvm;
|
|
|
|
void MCAsmInfoCOFF::anchor() {}
|
|
|
|
MCAsmInfoCOFF::MCAsmInfoCOFF() {
|
|
// MingW 4.5 and later support .comm with log2 alignment, but .lcomm uses byte
|
|
// alignment.
|
|
COMMDirectiveAlignmentIsInBytes = false;
|
|
LCOMMDirectiveAlignmentType = LCOMM::ByteAlignment;
|
|
HasDotTypeDotSizeDirective = false;
|
|
HasSingleParameterDotFile = false;
|
|
WeakRefDirective = "\t.weak\t";
|
|
HasLinkOnceDirective = true;
|
|
|
|
// Doesn't support visibility:
|
|
HiddenVisibilityAttr = HiddenDeclarationVisibilityAttr = MCSA_Invalid;
|
|
ProtectedVisibilityAttr = MCSA_Invalid;
|
|
|
|
// Set up DWARF directives
|
|
SupportsDebugInformation = true;
|
|
NeedsDwarfSectionOffsetDirective = true;
|
|
|
|
UseIntegratedAssembler = true;
|
|
|
|
// At least MSVC inline-asm does AShr.
|
|
UseLogicalShr = false;
|
|
|
|
// If this is a COFF target, assume that it supports associative comdats. It's
|
|
// part of the spec.
|
|
HasCOFFAssociativeComdats = true;
|
|
}
|
|
|
|
void MCAsmInfoMicrosoft::anchor() {}
|
|
|
|
MCAsmInfoMicrosoft::MCAsmInfoMicrosoft() = default;
|
|
|
|
void MCAsmInfoGNUCOFF::anchor() {}
|
|
|
|
MCAsmInfoGNUCOFF::MCAsmInfoGNUCOFF() {
|
|
// If this is a GNU environment (mingw or cygwin), don't use associative
|
|
// comdats for jump tables, unwind information, and other data associated with
|
|
// a function.
|
|
HasCOFFAssociativeComdats = false;
|
|
}
|