llvm/lib/CodeGen
Duncan Sands 1df9859c40 There are two ways of checking for a given type, for example isa<PointerType>(T)
and T->isPointerTy().  Convert most instances of the first form to the second form.
Requested by Chris.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@96344 91177308-0d34-0410-b5e6-96231b3b80d8
2010-02-16 11:11:14 +00:00
..
AsmPrinter Use ttype encoding consistently 2010-02-15 22:38:25 +00:00
PBQP * Updated the cost matrix normalization proceedure to better handle infinite costs. 2010-02-12 09:43:37 +00:00
SelectionDAG There are two ways of checking for a given type, for example isa<PointerType>(T) 2010-02-16 11:11:14 +00:00
AggressiveAntiDepBreaker.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
AggressiveAntiDepBreaker.h 80 column and whitespace cleanup 2010-01-06 16:48:02 +00:00
AntiDepBreaker.h Remove some old experimental code that is no longer needed. Remove additional, speculative scheduling pass as its cost did not translate into significant performance improvement. Minor tweaks. 2009-11-20 19:32:48 +00:00
BranchFolding.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
BranchFolding.h Split tail duplication into a separate pass. This is needed to avoid 2009-11-26 00:32:21 +00:00
CalcSpillWeights.cpp Remove duplicated #include. 2010-02-10 01:22:57 +00:00
CMakeLists.txt Add missed entry to cmake build list file 2010-02-15 22:55:13 +00:00
CodePlacementOpt.cpp Fix several comments which had previously been "the the" where a 2010-02-10 20:04:19 +00:00
CriticalAntiDepBreaker.cpp Anti-dependency breaking needs to be careful regarding instructions with 2010-01-06 22:21:25 +00:00
CriticalAntiDepBreaker.h Anti-dependency breaking needs to be careful regarding instructions with 2010-01-06 22:21:25 +00:00
DeadMachineInstructionElim.cpp Rewrite handling of DBG_VALUE; previous algorithm 2010-02-12 18:40:17 +00:00
DwarfEHPrepare.cpp SjLj EH introduces can introduce an additional edge to a landing pad and pad 2010-01-20 23:03:55 +00:00
ELF.h Fix a bunch of little errors that Clang complains about when its being pedantic 2009-12-19 07:05:23 +00:00
ELFCodeEmitter.cpp prep work to support a future where getJumpTableInfo will return 2010-01-25 23:22:00 +00:00
ELFCodeEmitter.h
ELFWriter.cpp remove dead #include, stupid symlinks. 2010-02-02 22:37:42 +00:00
ELFWriter.h
ExactHazardRecognizer.cpp Fix "the the" and similar typos. 2010-02-10 16:03:48 +00:00
ExactHazardRecognizer.h
GCMetadata.cpp Change errs() to dbgs(). 2010-01-04 21:35:15 +00:00
GCMetadataPrinter.cpp
GCStrategy.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
IfConversion.cpp Change errs() to dbgs(). 2010-01-04 22:02:01 +00:00
IntrinsicLowering.cpp Uniformize the names of type predicates: rather than having isFloatTy and 2010-02-15 16:12:20 +00:00
LatencyPriorityQueue.cpp Remove some old experimental code that is no longer needed. Remove additional, speculative scheduling pass as its cost did not translate into significant performance improvement. Minor tweaks. 2009-11-20 19:32:48 +00:00
LiveInterval.cpp Fix a comment typo. 2010-01-12 22:18:56 +00:00
LiveIntervalAnalysis.cpp When I rewrote this loop per Chris' preference I 2010-02-10 21:41:41 +00:00
LiveStackAnalysis.cpp The Indexes Patch. 2009-11-03 23:52:08 +00:00
LiveVariables.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
LLVMTargetMachine.cpp Besides removing phi cycles that reduce to a single value, also remove dead 2010-02-13 00:31:44 +00:00
LowerSubregs.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
MachineBasicBlock.cpp Fix comments to reflect renaming elsewhere. 2010-02-10 00:11:11 +00:00
MachineDominators.cpp Explicit template instantiations must happen in the template's immediately 2009-12-16 00:13:24 +00:00
MachineFunction.cpp Fix "the the" and similar typos. 2010-02-10 16:03:48 +00:00
MachineFunctionAnalysis.cpp make MachineFunction keep track of its ID and make 2010-01-26 04:35:26 +00:00
MachineFunctionPass.cpp
MachineInstr.cpp Add non-temporal flags to MachineMemOperand. 2010-02-15 16:48:31 +00:00
MachineLICM.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
MachineLoopInfo.cpp Restore dump() methods to Loop and MachineLoop. 2010-01-05 21:08:02 +00:00
MachineModuleInfo.cpp Fix an uninitialized value. Radar 7609421. 2010-02-06 05:55:20 +00:00
MachineModuleInfoImpls.cpp Preliminary patch to improve dwarf EH generation - Hooks to return Personality / FDE / LSDA / TType encoding depending on target / options (e.g. code model / relocation model) - MCIzation of Dwarf EH printer to use encoding information - Stub generation for ELF target (needed for indirect references) - Some other small changes here and there 2010-02-15 22:35:59 +00:00
MachinePassRegistry.cpp
MachineRegisterInfo.cpp
MachineSink.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
MachineSSAUpdater.cpp fix missing #includes. 2010-02-10 01:17:36 +00:00
MachineVerifier.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
Makefile make -fno-rtti the default unless a directory builds with REQUIRES_RTTI. 2010-01-24 20:43:08 +00:00
ObjectCodeEmitter.cpp
OcamlGC.cpp Remove includes of Support/Compiler.h that are no longer needed after the 2009-10-25 06:57:41 +00:00
OptimizeExts.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
OptimizePHIs.cpp Besides removing phi cycles that reduce to a single value, also remove dead 2010-02-13 00:31:44 +00:00
Passes.cpp
PHIElimination.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
PHIElimination.h Handle DBG_VALUE mixed with labels when doing PHI 2010-02-16 01:57:28 +00:00
PostRASchedulerList.cpp Change errs() to dbgs(). 2010-01-05 01:26:01 +00:00
PreAllocSplitting.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
ProcessImplicitDefs.cpp Fix PR6300. 2010-02-15 22:03:29 +00:00
PrologEpilogInserter.cpp Teach MachineFrameInfo to track maximum alignment while stack objects are being 2010-02-13 01:56:41 +00:00
PrologEpilogInserter.h
PseudoSourceValue.cpp Do some cleanups suggested by Chris. 2009-11-12 21:49:55 +00:00
README.txt
RegAllocLinearScan.cpp Change errs() to dbgs(). 2010-01-05 01:25:20 +00:00
RegAllocLocal.cpp Reapply 96294; now that I've gotten around to looking 2010-02-16 01:27:47 +00:00
RegAllocPBQP.cpp Fixed a bug in the PBQP allocator's findCoalesces method. 2010-02-09 00:50:27 +00:00
RegisterCoalescer.cpp
RegisterScavenging.cpp improve portability to avoid conflicting with std::next in c++'0x. 2009-12-03 00:50:42 +00:00
ScheduleDAG.cpp Change errs() to dbgs(). 2010-01-05 01:25:41 +00:00
ScheduleDAGEmit.cpp Add assertion checks here to turn silent miscompiles into aborts. 2009-10-30 23:59:06 +00:00
ScheduleDAGInstrs.cpp There are two ways of checking for a given type, for example isa<PointerType>(T) 2010-02-16 11:11:14 +00:00
ScheduleDAGInstrs.h
ScheduleDAGPrinter.cpp Remove ShortNames from getNodeLabel in DOTGraphTraits 2009-11-30 12:38:47 +00:00
ShadowStackGC.cpp Remove includes of Support/Compiler.h that are no longer needed after the 2009-10-25 06:57:41 +00:00
ShrinkWrapping.cpp Change errs() to dbgs(). 2010-01-05 01:25:39 +00:00
SimpleHazardRecognizer.h
SimpleRegisterCoalescing.cpp Fix PR6283. 2010-02-13 02:06:10 +00:00
SimpleRegisterCoalescing.h Fix a bunch of little errors that Clang complains about when its being pedantic 2009-12-19 07:05:23 +00:00
SjLjEHPrepare.cpp Update of 94055 to track the IR level call site information via an intrinsic. 2010-01-28 01:45:32 +00:00
SlotIndexes.cpp Fix "the the" and similar typos. 2010-02-10 16:03:48 +00:00
Spiller.cpp Change errs() to dbgs(). 2010-01-05 01:25:55 +00:00
Spiller.h Added a new "splitting" spiller. 2009-12-09 05:39:12 +00:00
StackProtector.cpp Uniformize the names of type predicates: rather than having isFloatTy and 2010-02-15 16:12:20 +00:00
StackSlotColoring.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
StrongPHIElimination.cpp Fix "the the" and similar typos. 2010-02-10 16:03:48 +00:00
TailDuplication.cpp Reuse operand location when updating PHI instructions. 2010-02-11 00:34:33 +00:00
TargetInstrInfoImpl.cpp Add Target hook to duplicate machine instructions. 2010-01-06 23:47:07 +00:00
TargetLoweringObjectFileImpl.cpp Move TLOF implementations to libCodegen to resolve layering violation. 2010-02-15 22:37:53 +00:00
TwoAddressInstructionPass.cpp Don't allow DBG_VALUE to affect codegen. 2010-02-11 18:22:31 +00:00
UnreachableBlockElim.cpp move target-independent opcodes out of TargetInstrInfo 2010-02-09 19:54:29 +00:00
VirtRegMap.cpp Fix "the the" and similar typos. 2010-02-10 16:03:48 +00:00
VirtRegMap.h The Indexes Patch. 2009-11-03 23:52:08 +00:00
VirtRegRewriter.cpp Fix PR6283. 2010-02-13 02:06:10 +00:00
VirtRegRewriter.h

//===---------------------------------------------------------------------===//

Common register allocation / spilling problem:

        mul lr, r4, lr
        str lr, [sp, #+52]
        ldr lr, [r1, #+32]
        sxth r3, r3
        ldr r4, [sp, #+52]
        mla r4, r3, lr, r4

can be:

        mul lr, r4, lr
        mov r4, lr
        str lr, [sp, #+52]
        ldr lr, [r1, #+32]
        sxth r3, r3
        mla r4, r3, lr, r4

and then "merge" mul and mov:

        mul r4, r4, lr
        str lr, [sp, #+52]
        ldr lr, [r1, #+32]
        sxth r3, r3
        mla r4, r3, lr, r4

It also increase the likelyhood the store may become dead.

//===---------------------------------------------------------------------===//

bb27 ...
        ...
        %reg1037 = ADDri %reg1039, 1
        %reg1038 = ADDrs %reg1032, %reg1039, %NOREG, 10
    Successors according to CFG: 0x8b03bf0 (#5)

bb76 (0x8b03bf0, LLVM BB @0x8b032d0, ID#5):
    Predecessors according to CFG: 0x8b0c5f0 (#3) 0x8b0a7c0 (#4)
        %reg1039 = PHI %reg1070, mbb<bb76.outer,0x8b0c5f0>, %reg1037, mbb<bb27,0x8b0a7c0>

Note ADDri is not a two-address instruction. However, its result %reg1037 is an
operand of the PHI node in bb76 and its operand %reg1039 is the result of the
PHI node. We should treat it as a two-address code and make sure the ADDri is
scheduled after any node that reads %reg1039.

//===---------------------------------------------------------------------===//

Use local info (i.e. register scavenger) to assign it a free register to allow
reuse:
        ldr r3, [sp, #+4]
        add r3, r3, #3
        ldr r2, [sp, #+8]
        add r2, r2, #2
        ldr r1, [sp, #+4]  <==
        add r1, r1, #1
        ldr r0, [sp, #+4]
        add r0, r0, #2

//===---------------------------------------------------------------------===//

LLVM aggressively lift CSE out of loop. Sometimes this can be negative side-
effects:

R1 = X + 4
R2 = X + 7
R3 = X + 15

loop:
load [i + R1]
...
load [i + R2]
...
load [i + R3]

Suppose there is high register pressure, R1, R2, R3, can be spilled. We need
to implement proper re-materialization to handle this:

R1 = X + 4
R2 = X + 7
R3 = X + 15

loop:
R1 = X + 4  @ re-materialized
load [i + R1]
...
R2 = X + 7 @ re-materialized
load [i + R2]
...
R3 = X + 15 @ re-materialized
load [i + R3]

Furthermore, with re-association, we can enable sharing:

R1 = X + 4
R2 = X + 7
R3 = X + 15

loop:
T = i + X
load [T + 4]
...
load [T + 7]
...
load [T + 15]
//===---------------------------------------------------------------------===//

It's not always a good idea to choose rematerialization over spilling. If all
the load / store instructions would be folded then spilling is cheaper because
it won't require new live intervals / registers. See 2003-05-31-LongShifts for
an example.

//===---------------------------------------------------------------------===//

With a copying garbage collector, derived pointers must not be retained across
collector safe points; the collector could move the objects and invalidate the
derived pointer. This is bad enough in the first place, but safe points can
crop up unpredictably. Consider:

        %array = load { i32, [0 x %obj] }** %array_addr
        %nth_el = getelementptr { i32, [0 x %obj] }* %array, i32 0, i32 %n
        %old = load %obj** %nth_el
        %z = div i64 %x, %y
        store %obj* %new, %obj** %nth_el

If the i64 division is lowered to a libcall, then a safe point will (must)
appear for the call site. If a collection occurs, %array and %nth_el no longer
point into the correct object.

The fix for this is to copy address calculations so that dependent pointers
are never live across safe point boundaries. But the loads cannot be copied
like this if there was an intervening store, so may be hard to get right.

Only a concurrent mutator can trigger a collection at the libcall safe point.
So single-threaded programs do not have this requirement, even with a copying
collector. Still, LLVM optimizations would probably undo a front-end's careful
work.

//===---------------------------------------------------------------------===//

The ocaml frametable structure supports liveness information. It would be good
to support it.

//===---------------------------------------------------------------------===//

The FIXME in ComputeCommonTailLength in BranchFolding.cpp needs to be
revisited. The check is there to work around a misuse of directives in inline
assembly.

//===---------------------------------------------------------------------===//

It would be good to detect collector/target compatibility instead of silently
doing the wrong thing.

//===---------------------------------------------------------------------===//

It would be really nice to be able to write patterns in .td files for copies,
which would eliminate a bunch of explicit predicates on them (e.g. no side 
effects).  Once this is in place, it would be even better to have tblgen 
synthesize the various copy insertion/inspection methods in TargetInstrInfo.

//===---------------------------------------------------------------------===//

Stack coloring improvments:

1. Do proper LiveStackAnalysis on all stack objects including those which are
   not spill slots.
2. Reorder objects to fill in gaps between objects.
   e.g. 4, 1, <gap>, 4, 1, 1, 1, <gap>, 4 => 4, 1, 1, 1, 1, 4, 4

//===---------------------------------------------------------------------===//

The scheduler should be able to sort nearby instructions by their address. For
example, in an expanded memset sequence it's not uncommon to see code like this:

  movl $0, 4(%rdi)
  movl $0, 8(%rdi)
  movl $0, 12(%rdi)
  movl $0, 0(%rdi)

Each of the stores is independent, and the scheduler is currently making an
arbitrary decision about the order.

//===---------------------------------------------------------------------===//

Another opportunitiy in this code is that the $0 could be moved to a register:

  movl $0, 4(%rdi)
  movl $0, 8(%rdi)
  movl $0, 12(%rdi)
  movl $0, 0(%rdi)

This would save substantial code size, especially for longer sequences like
this. It would be easy to have a rule telling isel to avoid matching MOV32mi
if the immediate has more than some fixed number of uses. It's more involved
to teach the register allocator how to do late folding to recover from
excessive register pressure.