mirror of
https://github.com/RPCS3/llvm.git
synced 2024-11-27 21:50:29 +00:00
143ef32e8f
the invalidation propagation logic from an SCC to a Function. I wrote the infrastructure to test this but didn't actually use it in the unit test where it was designed to be used. =[ My bad. Once I actually added it to the test case I discovered that it also hadn't been properly implemented, so I've implemented it. The logic in the FAM proxy for an SCC pass to propagate invalidation follows the same ideas as the FAM proxy for a Module pass, but the implementation is a bit different to reflect the fact that it is forwarding just for an SCC. However, implementing this correctly uncovered a surprising "bug" (it was conservatively correct but relatively very expensive) in how we handle invalidation when splitting one SCC into multiple SCCs. We did an eager invalidation when in reality we should be deferring invaliadtion for the *current* SCC to the CGSCC pass manager and just invaliating the newly constructed SCCs. Otherwise we end up invalidating too much too soon. This was exposed by the inliner test case that I've updated. Now, we invalidate *just* the split off '(test1_f)' SCC when doing the CG update, and then the inliner finishes and invalidates the '(test1_g, test1_h)' SCC's analyses. The first few attempts at fixing this hit still more bugs, but all of those are covered by existing tests. For example, the inliner should also preserve the FAM proxy to avoid unnecesasry invalidation, and this is safe because the CG update routines it uses handle any necessary adjustments to the FAM proxy. Finally, the unittests for the CGSCC pass manager needed a bunch of updates where we weren't correctly preserving the FAM proxy because it hadn't been fully implemented and failing to preserve it didn't matter. Note that this doesn't yet fix the current crasher due to MemSSA finding a stale dominator tree, but without this the fix to that crasher doesn't really make any sense when testing because it relies on the proxy behavior. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@307487 91177308-0d34-0410-b5e6-96231b3b80d8 |
||
|---|---|---|
| .. | ||
| AliasAnalysisTest.cpp | ||
| AliasSetTrackerTest.cpp | ||
| BlockFrequencyInfoTest.cpp | ||
| BranchProbabilityInfoTest.cpp | ||
| CallGraphTest.cpp | ||
| CFGTest.cpp | ||
| CGSCCPassManagerTest.cpp | ||
| CMakeLists.txt | ||
| GlobalsModRefTest.cpp | ||
| LazyCallGraphTest.cpp | ||
| LoopInfoTest.cpp | ||
| MemoryBuiltinsTest.cpp | ||
| MemorySSA.cpp | ||
| OrderedBasicBlockTest.cpp | ||
| ProfileSummaryInfoTest.cpp | ||
| ScalarEvolutionTest.cpp | ||
| TargetLibraryInfoTest.cpp | ||
| TBAATest.cpp | ||
| UnrollAnalyzer.cpp | ||
| ValueTrackingTest.cpp | ||