Sanjay Patel dbd50cefa1 set div/rem default values to 'expensive' in TargetTransformInfo's cost model ...

...because that's what the cost model was intended to do.

As discussed in D12882, this fix has a temporary unintended consequence for
SimplifyCFG: it causes us to not speculate an fdiv. However, two wrongs make
PR24818 right, and two wrongs make PR24343 act right even though it's really
still wrong.

I intend to correct SimplifyCFG and add to CodeGenPrepare to account for this
cost model change and preserve the righteousness for the bug report cases.

https://llvm.org/bugs/show_bug.cgi?id=24818
https://llvm.org/bugs/show_bug.cgi?id=24343

Differential Revision: http://reviews.llvm.org/D12882



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@248439 91177308-0d34-0410-b5e6-96231b3b80d8

2015-09-23 22:28:18 +00:00

..

AArch64

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

AMDGPU

AMDGPU: Fix some places missed in rename

2015-06-19 17:39:03 +00:00

PowerPC

[CodeGenPrepare] Removed duplicate logic. SimplifyCFG already knows how to speculate calls to cttz/ctlz.

2015-02-13 14:15:48 +00:00

SPARC

Reduce verbiage of lit.local.cfg files

2014-06-09 22:42:55 +00:00

X86

Changed renaming of local symbols by inserting a dot vefore the numeric suffix.

2015-05-12 16:47:30 +00:00

2002-05-21-PHIElimination.ll

…

2002-09-24-PHIAssertion.ll

…

2003-03-07-DominateProblem.ll

…

2003-08-05-InvokeCrash.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

2003-08-17-BranchFold.ll

Converted 8x tests of SimplifyCFG to use FileCheck instead of grep.

2013-04-09 05:18:53 +00:00

2003-08-17-BranchFoldOrdering.ll

Converted 8x tests of SimplifyCFG to use FileCheck instead of grep.

2013-04-09 05:18:53 +00:00

2003-08-17-FoldSwitch-dbg.ll

[opaque pointer type] Add textual IR support for explicit type parameter to gep operator

2015-03-13 18:20:45 +00:00

2003-08-17-FoldSwitch.ll

Converted 8x tests of SimplifyCFG to use FileCheck instead of grep.

2013-04-09 05:18:53 +00:00

2004-12-10-SimplifyCFGCrash.ll

…

2005-06-16-PHICrash.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2005-08-01-PHIUpdateFail.ll

[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

2015-02-27 19:29:02 +00:00

2005-10-02-InvokeSimplify.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

2005-12-03-IncorrectPHIFold.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2006-02-17-InfiniteUnroll.ll

…

2006-06-12-InfLoop.ll

…

2006-08-03-Crash.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2006-10-19-UncondDiv.ll

Converted 8x tests of SimplifyCFG to use FileCheck instead of grep.

2013-04-09 05:18:53 +00:00

2006-12-08-Ptr-ICmp-Branch.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2007-11-22-InvokeNoUnwind.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

2007-12-21-Crash.ll

[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction

2015-04-16 23:24:18 +00:00

2008-01-02-hoist-fp-add.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2008-05-16-PHIBlockMerge.ll

Convert all tests using TCL-style quoting to use shell-style quoting.

2012-07-02 12:47:22 +00:00

2008-07-13-InfLoopMiscompile.ll

[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction

2015-04-16 23:24:18 +00:00

2008-09-08-MultiplePred.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2008-09-17-SpeculativeHoist.ll

…

2008-10-03-SpeculativelyExecuteBeforePHI.ll

…

2008-12-06-SingleEntryPhi.ll

…

2008-12-16-DCECond.ll

[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction

2015-04-16 23:24:18 +00:00

2009-01-18-PHIPropCrash.ll

…

2009-01-19-UnconditionalTrappingConstantExpr.ll

Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.

2013-07-14 01:42:54 +00:00

2009-05-12-externweak.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2010-03-30-InvokeCrash.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

2011-03-08-UnreachableUse.ll

PR9420; an instruction before an unreachable is guaranteed not to have any

2011-03-09 00:48:33 +00:00

2011-09-05-TrivialLPad.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

assume.ll

Add @llvm.assume, lowering, and some basic properties

2014-07-25 21:13:35 +00:00

attr-noduplicate.ll

[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

2015-02-27 19:29:02 +00:00

basictest.ll

DI: Require subprogram definitions to be distinct

2015-08-28 20:26:49 +00:00

branch-cond-merge.ll

…

branch-cond-prop.ll

…

branch-fold-dbg.ll

DI: Require subprogram definitions to be distinct

2015-08-28 20:26:49 +00:00

branch-fold-test.ll

…

branch-fold-threshold.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

branch-fold.ll

Remove dyn_cast + dereference pattern by replacing it with a cast and changing

2012-06-24 10:15:42 +00:00

branch-phi-thread.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

BrUnwind.ll

Fix the remaining TCL-style quotes found in the testsuite. This is

2012-07-02 19:09:46 +00:00

clamp.ll

[SimplifyCFG] Add test for r229099

2015-02-13 11:08:40 +00:00

common-dest-folding.ll

[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction

2015-04-16 23:24:18 +00:00

CoveredLookupTable.ll

Teach simplify-cfg how to correctly create covered lookup tables for switches on iN with N >= 3.

2013-10-20 07:04:37 +00:00

dbginfo.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

dce-cond-after-folding-terminator.ll

Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.

2013-07-14 01:42:54 +00:00

DeadSetCC.ll

Fix the remaining TCL-style quotes found in the testsuite. This is

2012-07-02 19:09:46 +00:00

duplicate-landingpad.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

duplicate-phis.ll

Convert all tests using TCL-style quoting to use shell-style quoting.

2012-07-02 12:47:22 +00:00

empty-cleanuppad.ll

[WinEH] Pull Adjectives and CatchObj out of the catchpad arg list

2015-09-16 20:16:27 +00:00

EmptyBlockMerge.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

EqualPHIEdgeBlockMerge.ll

TryToSimplifyUncondBranchFromEmptyBlock was checking that any common

2013-07-11 08:28:20 +00:00

extract-cost.ll

Add ExtractValue instruction to SimplifyCFG's ComputeSpeculationCost

2014-05-09 17:02:46 +00:00

ForwardSwitchConditionToPHI.ll

Fix PR10103: Less code for enum type translation.

2011-06-18 10:28:47 +00:00

hoist-common-code.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

hoist-dbgvalue.ll

DI: Require subprogram definitions to be distinct

2015-08-28 20:26:49 +00:00

hoist-with-range.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

HoistCode.ll

…

indirectbr.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

invoke_unwind.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

invoke.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

iterative-simplify.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

lifetime.ll

SimplifyCFG: Avoid miscompilations due to removed lifetime intrinsics.

2014-07-30 21:04:00 +00:00

MagicPointer.ll

[opaque pointer type] Add textual IR support for explicit type parameter to gep operator

2015-03-13 18:20:45 +00:00

multiple-phis.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

no_speculative_loads_with_tsan.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

noreturn-call.ll

…

phi-undef-loadstore.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

PhiBlockMerge2.ll

…

PhiBlockMerge.ll

[SimplifyCFG] Swap to using TargetTransformInfo for cost

2015-02-11 12:15:41 +00:00

PhiEliminate2.ll

SimplifyCFG: Add Trunc, ZExt and SExt to the list of cheap instructions for phi node folding

2011-04-29 18:47:25 +00:00

PhiEliminate3.ll

SimplifyCFG: Expose phi node folding cost threshold as command line parameter

2011-04-29 18:47:38 +00:00

PhiEliminate.ll

- Insert new instructions before DomBlock's terminator,

2010-12-14 08:46:09 +00:00

PHINode.ll

Filecheckized 2x tests in SimplifyCFG and removed their date prefix to fit with current llvm style for test names.

2013-01-31 01:04:23 +00:00

PhiNoEliminate.ll

…

PR9946.ll

Tests: rewrite 'opt ... %s' to 'opt ... < %s' so that opt does not emit a ModuleID

2013-01-01 13:57:25 +00:00

PR16069.ll

Second part of pr16069

2013-06-04 14:11:59 +00:00

PR17073.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

preserve-branchweights-partial.ll

IR: Make metadata typeless in assembly

2014-12-15 19:07:53 +00:00

preserve-branchweights-switch-create.ll

IR: Make metadata typeless in assembly

2014-12-15 19:07:53 +00:00

preserve-branchweights.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

preserve-make-implicit-on-switch-to-br.ll

[ConstantFoldTerminator] Preserve make.implicit metadata when converting SwitchInst to BranchInst

2015-08-07 19:30:12 +00:00

return-merge.ll

…

seh-nounwind.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

select-gep.ll

[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

2015-02-27 19:29:02 +00:00

sink-common-code.ll

[SimplifyCFG] Revise common code sinking

2014-12-23 08:26:55 +00:00

speculate-math.ll

set div/rem default values to 'expensive' in TargetTransformInfo's cost model

2015-09-23 22:28:18 +00:00

speculate-store.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

speculate-vector-ops.ll

Make bitcast, extractelement, and insertelement considered cheap for speculation.

2014-05-30 18:34:43 +00:00

speculate-with-offset.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

SpeculativeExec.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

statepoint-invoke-unwind.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

switch_create.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

switch_switch_fold.ll

…

switch_thread.ll

Fix the remaining TCL-style quotes found in the testsuite. This is

2012-07-02 19:09:46 +00:00

switch-dead-default.ll

[SimplifyCFG] Use known bits to eliminate dead switch defaults

2015-09-10 17:44:47 +00:00

switch-masked-bits.ll

Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.

2013-07-14 01:42:54 +00:00

switch-on-const-select.ll

Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.

2013-07-14 01:42:54 +00:00

switch-range-to-icmp.ll

SimplifyCFG: don't remove unreachable default switch destinations

2015-01-26 19:52:32 +00:00

switch-simplify-crash.ll

…

switch-to-br.ll

Add some tests for SimplifyCFG's ConstantFoldTerminator(). NFC.

2014-12-04 22:19:25 +00:00

switch-to-icmp.ll

Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.

2013-07-14 01:42:54 +00:00

switch-to-select-multiple-edge-per-block-phi.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

switch-to-select-two-case.ll

SimplifyCFG: don't remove unreachable default switch destinations

2015-01-26 19:52:32 +00:00

trap-debugloc.ll

DI: Require subprogram definitions to be distinct

2015-08-28 20:26:49 +00:00

trapping-load-unreachable.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

two-entry-phi-return.ll

…

UncondBranchToReturn.ll

Fix the remaining TCL-style quotes found in the testsuite. This is

2012-07-02 19:09:46 +00:00

unreachable-blocks.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

UnreachableEliminate.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

volatile-phioper.ll

[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction

2015-04-16 23:24:18 +00:00