mirror of
https://github.com/RPCS3/llvm.git
synced 2025-05-23 22:06:19 +00:00
0995a92322
When investigating bugs in PDB generation, the first step is often to do the same link with link.exe and then compare PDBs. But comparing PDBs is hard because two completely different byte sequences can both be correct, so it hampers the investigation when you also have to spend time figuring out not just which bytes are different, but also if the difference is meaningful. This patch fixes a couple of cases related to string table emission, hash table emission, and the order in which we emit strings that makes more of our bytes the same as the bytes generated by MS PDBs. Differential Revision: https://reviews.llvm.org/D44810 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@328348 91177308-0d34-0410-b5e6-96231b3b80d8
79 lines
2.6 KiB
C++
79 lines
2.6 KiB
C++
//===- InfoStreamBuilder.cpp - PDB Info Stream Creation ---------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/DebugInfo/PDB/Native/InfoStreamBuilder.h"
|
|
|
|
#include "llvm/DebugInfo/MSF/MSFBuilder.h"
|
|
#include "llvm/DebugInfo/MSF/MappedBlockStream.h"
|
|
#include "llvm/DebugInfo/PDB/Native/InfoStream.h"
|
|
#include "llvm/DebugInfo/PDB/Native/NamedStreamMap.h"
|
|
#include "llvm/DebugInfo/PDB/Native/PDBFileBuilder.h"
|
|
#include "llvm/DebugInfo/PDB/Native/RawError.h"
|
|
#include "llvm/DebugInfo/PDB/Native/RawTypes.h"
|
|
#include "llvm/Support/BinaryStreamWriter.h"
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::codeview;
|
|
using namespace llvm::msf;
|
|
using namespace llvm::pdb;
|
|
|
|
InfoStreamBuilder::InfoStreamBuilder(msf::MSFBuilder &Msf,
|
|
NamedStreamMap &NamedStreams)
|
|
: Msf(Msf), Ver(PdbRaw_ImplVer::PdbImplVC70), Age(0),
|
|
NamedStreams(NamedStreams) {
|
|
::memset(&Guid, 0, sizeof(Guid));
|
|
}
|
|
|
|
void InfoStreamBuilder::setVersion(PdbRaw_ImplVer V) { Ver = V; }
|
|
|
|
void InfoStreamBuilder::setAge(uint32_t A) { Age = A; }
|
|
|
|
void InfoStreamBuilder::setSignature(uint32_t S) { Signature = S; }
|
|
|
|
void InfoStreamBuilder::setGuid(GUID G) { Guid = G; }
|
|
|
|
void InfoStreamBuilder::addFeature(PdbRaw_FeatureSig Sig) {
|
|
Features.push_back(Sig);
|
|
}
|
|
|
|
Error InfoStreamBuilder::finalizeMsfLayout() {
|
|
uint32_t Length = sizeof(InfoStreamHeader) +
|
|
NamedStreams.calculateSerializedLength() +
|
|
(Features.size() + 1) * sizeof(uint32_t);
|
|
if (auto EC = Msf.setStreamSize(StreamPDB, Length))
|
|
return EC;
|
|
return Error::success();
|
|
}
|
|
|
|
Error InfoStreamBuilder::commit(const msf::MSFLayout &Layout,
|
|
WritableBinaryStreamRef Buffer) const {
|
|
auto InfoS = WritableMappedBlockStream::createIndexedStream(
|
|
Layout, Buffer, StreamPDB, Msf.getAllocator());
|
|
BinaryStreamWriter Writer(*InfoS);
|
|
|
|
InfoStreamHeader H;
|
|
// Leave the build id fields 0 so they can be set as the last step before
|
|
// committing the file to disk.
|
|
::memset(&H, 0, sizeof(H));
|
|
H.Version = Ver;
|
|
if (auto EC = Writer.writeObject(H))
|
|
return EC;
|
|
|
|
if (auto EC = NamedStreams.commit(Writer))
|
|
return EC;
|
|
if (auto EC = Writer.writeInteger(0))
|
|
return EC;
|
|
for (auto E : Features) {
|
|
if (auto EC = Writer.writeEnum(E))
|
|
return EC;
|
|
}
|
|
assert(Writer.bytesRemaining() == 0);
|
|
return Error::success();
|
|
}
|