mirror of
https://github.com/RPCS3/llvm.git
synced 2025-05-23 22:06:19 +00:00

The hash table is a list of buckets, and the *value* stored in the bucket cannot be 0 since that is reserved. However, the code here was incorrectly skipping over the 0'th bucket entirely. The 0'th bucket is perfectly fine, just none of these buckets can contain the value 0. As a result, whenever there was a string where hash(S) % Size was equal to 0, we would write the value in the next bucket instead. We never caught this in our tests due to *another* bug, which is that we would iterate the entire list of buckets looking for the value, only using the hash value as a starting point. However, the real algorithm stops when it finds 0 in a bucket since it takes that to mean "the item is not in the hash table". The unit test is updated to carefully construct a set of hash values that will cause one item to hash to 0 mod bucket count, and the reader is also updated to return an error indicating that the item is not found when it encounters a 0 bucket. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@328162 91177308-0d34-0410-b5e6-96231b3b80d8
142 lines
4.5 KiB
C++
142 lines
4.5 KiB
C++
//===- PDBStringTable.cpp - PDB String Table ---------------------*- C++-*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/DebugInfo/PDB/Native/PDBStringTable.h"
|
|
|
|
#include "llvm/ADT/ArrayRef.h"
|
|
#include "llvm/DebugInfo/PDB/Native/Hash.h"
|
|
#include "llvm/DebugInfo/PDB/Native/RawError.h"
|
|
#include "llvm/DebugInfo/PDB/Native/RawTypes.h"
|
|
#include "llvm/Support/BinaryStreamReader.h"
|
|
#include "llvm/Support/Endian.h"
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::support;
|
|
using namespace llvm::pdb;
|
|
|
|
uint32_t PDBStringTable::getByteSize() const { return Header->ByteSize; }
|
|
uint32_t PDBStringTable::getNameCount() const { return NameCount; }
|
|
uint32_t PDBStringTable::getHashVersion() const { return Header->HashVersion; }
|
|
uint32_t PDBStringTable::getSignature() const { return Header->Signature; }
|
|
|
|
Error PDBStringTable::readHeader(BinaryStreamReader &Reader) {
|
|
if (auto EC = Reader.readObject(Header))
|
|
return EC;
|
|
|
|
if (Header->Signature != PDBStringTableSignature)
|
|
return make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Invalid hash table signature");
|
|
if (Header->HashVersion != 1 && Header->HashVersion != 2)
|
|
return make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Unsupported hash version");
|
|
|
|
assert(Reader.bytesRemaining() == 0);
|
|
return Error::success();
|
|
}
|
|
|
|
Error PDBStringTable::readStrings(BinaryStreamReader &Reader) {
|
|
BinaryStreamRef Stream;
|
|
if (auto EC = Reader.readStreamRef(Stream))
|
|
return EC;
|
|
|
|
if (auto EC = Strings.initialize(Stream)) {
|
|
return joinErrors(std::move(EC),
|
|
make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Invalid hash table byte length"));
|
|
}
|
|
|
|
assert(Reader.bytesRemaining() == 0);
|
|
return Error::success();
|
|
}
|
|
|
|
const codeview::DebugStringTableSubsectionRef &
|
|
PDBStringTable::getStringTable() const {
|
|
return Strings;
|
|
}
|
|
|
|
Error PDBStringTable::readHashTable(BinaryStreamReader &Reader) {
|
|
const support::ulittle32_t *HashCount;
|
|
if (auto EC = Reader.readObject(HashCount))
|
|
return EC;
|
|
|
|
if (auto EC = Reader.readArray(IDs, *HashCount)) {
|
|
return joinErrors(std::move(EC),
|
|
make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Could not read bucket array"));
|
|
}
|
|
|
|
return Error::success();
|
|
}
|
|
|
|
Error PDBStringTable::readEpilogue(BinaryStreamReader &Reader) {
|
|
if (auto EC = Reader.readInteger(NameCount))
|
|
return EC;
|
|
|
|
assert(Reader.bytesRemaining() == 0);
|
|
return Error::success();
|
|
}
|
|
|
|
Error PDBStringTable::reload(BinaryStreamReader &Reader) {
|
|
|
|
BinaryStreamReader SectionReader;
|
|
|
|
std::tie(SectionReader, Reader) = Reader.split(sizeof(PDBStringTableHeader));
|
|
if (auto EC = readHeader(SectionReader))
|
|
return EC;
|
|
|
|
std::tie(SectionReader, Reader) = Reader.split(Header->ByteSize);
|
|
if (auto EC = readStrings(SectionReader))
|
|
return EC;
|
|
|
|
// We don't know how long the hash table is until we parse it, so let the
|
|
// function responsible for doing that figure it out.
|
|
if (auto EC = readHashTable(Reader))
|
|
return EC;
|
|
|
|
std::tie(SectionReader, Reader) = Reader.split(sizeof(uint32_t));
|
|
if (auto EC = readEpilogue(SectionReader))
|
|
return EC;
|
|
|
|
assert(Reader.bytesRemaining() == 0);
|
|
return Error::success();
|
|
}
|
|
|
|
Expected<StringRef> PDBStringTable::getStringForID(uint32_t ID) const {
|
|
return Strings.getString(ID);
|
|
}
|
|
|
|
Expected<uint32_t> PDBStringTable::getIDForString(StringRef Str) const {
|
|
uint32_t Hash =
|
|
(Header->HashVersion == 1) ? hashStringV1(Str) : hashStringV2(Str);
|
|
size_t Count = IDs.size();
|
|
uint32_t Start = Hash % Count;
|
|
for (size_t I = 0; I < Count; ++I) {
|
|
// The hash is just a starting point for the search, but if it
|
|
// doesn't work we should find the string no matter what, because
|
|
// we iterate the entire array.
|
|
uint32_t Index = (Start + I) % Count;
|
|
|
|
// If we find 0, it means the item isn't in the hash table.
|
|
uint32_t ID = IDs[Index];
|
|
if (ID == 0)
|
|
return make_error<RawError>(raw_error_code::no_entry);
|
|
auto ExpectedStr = getStringForID(ID);
|
|
if (!ExpectedStr)
|
|
return ExpectedStr.takeError();
|
|
|
|
if (*ExpectedStr == Str)
|
|
return ID;
|
|
}
|
|
return make_error<RawError>(raw_error_code::no_entry);
|
|
}
|
|
|
|
FixedStreamArray<support::ulittle32_t> PDBStringTable::name_ids() const {
|
|
return IDs;
|
|
}
|