mirror of
https://github.com/RPCS3/llvm.git
synced 2025-02-14 15:57:47 +00:00
![Duncan P. N. Exon Smith](/assets/img/avatar_default.png)
Avoid implicit iterator conversions from MachineInstrBundleIterator to MachineInstr* in the Hexagon backend, mostly by preferring MachineInstr& over MachineInstr* and switching to range-based for loops. There's a long tail of API cleanup here, but I'm planning to leave the rest to the Hexagon maintainers. HexagonInstrInfo defines many of its own predicates, and most of them still take MachineInstr*. Some of those actually check for nullptr, so I didn't feel comfortable changing them to MachineInstr& en masse. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@275142 91177308-0d34-0410-b5e6-96231b3b80d8
336 lines
11 KiB
C++
336 lines
11 KiB
C++
//===-- HexagonPeephole.cpp - Hexagon Peephole Optimiztions ---------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
// This peephole pass optimizes in the following cases.
|
|
// 1. Optimizes redundant sign extends for the following case
|
|
// Transform the following pattern
|
|
// %vreg170<def> = SXTW %vreg166
|
|
// ...
|
|
// %vreg176<def> = COPY %vreg170:subreg_loreg
|
|
//
|
|
// Into
|
|
// %vreg176<def> = COPY vreg166
|
|
//
|
|
// 2. Optimizes redundant negation of predicates.
|
|
// %vreg15<def> = CMPGTrr %vreg6, %vreg2
|
|
// ...
|
|
// %vreg16<def> = NOT_p %vreg15<kill>
|
|
// ...
|
|
// JMP_c %vreg16<kill>, <BB#1>, %PC<imp-def,dead>
|
|
//
|
|
// Into
|
|
// %vreg15<def> = CMPGTrr %vreg6, %vreg2;
|
|
// ...
|
|
// JMP_cNot %vreg15<kill>, <BB#1>, %PC<imp-def,dead>;
|
|
//
|
|
// Note: The peephole pass makes the instrucstions like
|
|
// %vreg170<def> = SXTW %vreg166 or %vreg16<def> = NOT_p %vreg15<kill>
|
|
// redundant and relies on some form of dead removal instructions, like
|
|
// DCE or DIE to actually eliminate them.
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "Hexagon.h"
|
|
#include "HexagonTargetMachine.h"
|
|
#include "llvm/ADT/DenseMap.h"
|
|
#include "llvm/ADT/Statistic.h"
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
#include "llvm/CodeGen/MachineInstrBuilder.h"
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
#include "llvm/CodeGen/Passes.h"
|
|
#include "llvm/IR/Constants.h"
|
|
#include "llvm/PassSupport.h"
|
|
#include "llvm/Support/CommandLine.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
#include "llvm/Target/TargetInstrInfo.h"
|
|
#include "llvm/Target/TargetMachine.h"
|
|
#include "llvm/Target/TargetRegisterInfo.h"
|
|
#include <algorithm>
|
|
|
|
using namespace llvm;
|
|
|
|
#define DEBUG_TYPE "hexagon-peephole"
|
|
|
|
static cl::opt<bool> DisableHexagonPeephole("disable-hexagon-peephole",
|
|
cl::Hidden, cl::ZeroOrMore, cl::init(false),
|
|
cl::desc("Disable Peephole Optimization"));
|
|
|
|
static cl::opt<bool> DisablePNotP("disable-hexagon-pnotp",
|
|
cl::Hidden, cl::ZeroOrMore, cl::init(false),
|
|
cl::desc("Disable Optimization of PNotP"));
|
|
|
|
static cl::opt<bool> DisableOptSZExt("disable-hexagon-optszext",
|
|
cl::Hidden, cl::ZeroOrMore, cl::init(true),
|
|
cl::desc("Disable Optimization of Sign/Zero Extends"));
|
|
|
|
static cl::opt<bool> DisableOptExtTo64("disable-hexagon-opt-ext-to-64",
|
|
cl::Hidden, cl::ZeroOrMore, cl::init(true),
|
|
cl::desc("Disable Optimization of extensions to i64."));
|
|
|
|
namespace llvm {
|
|
FunctionPass *createHexagonPeephole();
|
|
void initializeHexagonPeepholePass(PassRegistry&);
|
|
}
|
|
|
|
namespace {
|
|
struct HexagonPeephole : public MachineFunctionPass {
|
|
const HexagonInstrInfo *QII;
|
|
const HexagonRegisterInfo *QRI;
|
|
const MachineRegisterInfo *MRI;
|
|
|
|
public:
|
|
static char ID;
|
|
HexagonPeephole() : MachineFunctionPass(ID) {
|
|
initializeHexagonPeepholePass(*PassRegistry::getPassRegistry());
|
|
}
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
|
|
|
const char *getPassName() const override {
|
|
return "Hexagon optimize redundant zero and size extends";
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
private:
|
|
void ChangeOpInto(MachineOperand &Dst, MachineOperand &Src);
|
|
};
|
|
}
|
|
|
|
char HexagonPeephole::ID = 0;
|
|
|
|
INITIALIZE_PASS(HexagonPeephole, "hexagon-peephole", "Hexagon Peephole",
|
|
false, false)
|
|
|
|
bool HexagonPeephole::runOnMachineFunction(MachineFunction &MF) {
|
|
if (skipFunction(*MF.getFunction()))
|
|
return false;
|
|
|
|
QII = static_cast<const HexagonInstrInfo *>(MF.getSubtarget().getInstrInfo());
|
|
QRI = MF.getSubtarget<HexagonSubtarget>().getRegisterInfo();
|
|
MRI = &MF.getRegInfo();
|
|
|
|
DenseMap<unsigned, unsigned> PeepholeMap;
|
|
DenseMap<unsigned, std::pair<unsigned, unsigned> > PeepholeDoubleRegsMap;
|
|
|
|
if (DisableHexagonPeephole) return false;
|
|
|
|
// Loop over all of the basic blocks.
|
|
for (MachineFunction::iterator MBBb = MF.begin(), MBBe = MF.end();
|
|
MBBb != MBBe; ++MBBb) {
|
|
MachineBasicBlock *MBB = &*MBBb;
|
|
PeepholeMap.clear();
|
|
PeepholeDoubleRegsMap.clear();
|
|
|
|
// Traverse the basic block.
|
|
for (MachineInstr &MI : *MBB) {
|
|
// Look for sign extends:
|
|
// %vreg170<def> = SXTW %vreg166
|
|
if (!DisableOptSZExt && MI.getOpcode() == Hexagon::A2_sxtw) {
|
|
assert(MI.getNumOperands() == 2);
|
|
MachineOperand &Dst = MI.getOperand(0);
|
|
MachineOperand &Src = MI.getOperand(1);
|
|
unsigned DstReg = Dst.getReg();
|
|
unsigned SrcReg = Src.getReg();
|
|
// Just handle virtual registers.
|
|
if (TargetRegisterInfo::isVirtualRegister(DstReg) &&
|
|
TargetRegisterInfo::isVirtualRegister(SrcReg)) {
|
|
// Map the following:
|
|
// %vreg170<def> = SXTW %vreg166
|
|
// PeepholeMap[170] = vreg166
|
|
PeepholeMap[DstReg] = SrcReg;
|
|
}
|
|
}
|
|
|
|
// Look for %vreg170<def> = COMBINE_ir_V4 (0, %vreg169)
|
|
// %vreg170:DoublRegs, %vreg169:IntRegs
|
|
if (!DisableOptExtTo64 && MI.getOpcode() == Hexagon::A4_combineir) {
|
|
assert(MI.getNumOperands() == 3);
|
|
MachineOperand &Dst = MI.getOperand(0);
|
|
MachineOperand &Src1 = MI.getOperand(1);
|
|
MachineOperand &Src2 = MI.getOperand(2);
|
|
if (Src1.getImm() != 0)
|
|
continue;
|
|
unsigned DstReg = Dst.getReg();
|
|
unsigned SrcReg = Src2.getReg();
|
|
PeepholeMap[DstReg] = SrcReg;
|
|
}
|
|
|
|
// Look for this sequence below
|
|
// %vregDoubleReg1 = LSRd_ri %vregDoubleReg0, 32
|
|
// %vregIntReg = COPY %vregDoubleReg1:subreg_loreg.
|
|
// and convert into
|
|
// %vregIntReg = COPY %vregDoubleReg0:subreg_hireg.
|
|
if (MI.getOpcode() == Hexagon::S2_lsr_i_p) {
|
|
assert(MI.getNumOperands() == 3);
|
|
MachineOperand &Dst = MI.getOperand(0);
|
|
MachineOperand &Src1 = MI.getOperand(1);
|
|
MachineOperand &Src2 = MI.getOperand(2);
|
|
if (Src2.getImm() != 32)
|
|
continue;
|
|
unsigned DstReg = Dst.getReg();
|
|
unsigned SrcReg = Src1.getReg();
|
|
PeepholeDoubleRegsMap[DstReg] =
|
|
std::make_pair(*&SrcReg, Hexagon::subreg_hireg);
|
|
}
|
|
|
|
// Look for P=NOT(P).
|
|
if (!DisablePNotP && MI.getOpcode() == Hexagon::C2_not) {
|
|
assert(MI.getNumOperands() == 2);
|
|
MachineOperand &Dst = MI.getOperand(0);
|
|
MachineOperand &Src = MI.getOperand(1);
|
|
unsigned DstReg = Dst.getReg();
|
|
unsigned SrcReg = Src.getReg();
|
|
// Just handle virtual registers.
|
|
if (TargetRegisterInfo::isVirtualRegister(DstReg) &&
|
|
TargetRegisterInfo::isVirtualRegister(SrcReg)) {
|
|
// Map the following:
|
|
// %vreg170<def> = NOT_xx %vreg166
|
|
// PeepholeMap[170] = vreg166
|
|
PeepholeMap[DstReg] = SrcReg;
|
|
}
|
|
}
|
|
|
|
// Look for copy:
|
|
// %vreg176<def> = COPY %vreg170:subreg_loreg
|
|
if (!DisableOptSZExt && MI.isCopy()) {
|
|
assert(MI.getNumOperands() == 2);
|
|
MachineOperand &Dst = MI.getOperand(0);
|
|
MachineOperand &Src = MI.getOperand(1);
|
|
|
|
// Make sure we are copying the lower 32 bits.
|
|
if (Src.getSubReg() != Hexagon::subreg_loreg)
|
|
continue;
|
|
|
|
unsigned DstReg = Dst.getReg();
|
|
unsigned SrcReg = Src.getReg();
|
|
if (TargetRegisterInfo::isVirtualRegister(DstReg) &&
|
|
TargetRegisterInfo::isVirtualRegister(SrcReg)) {
|
|
// Try to find in the map.
|
|
if (unsigned PeepholeSrc = PeepholeMap.lookup(SrcReg)) {
|
|
// Change the 1st operand.
|
|
MI.RemoveOperand(1);
|
|
MI.addOperand(MachineOperand::CreateReg(PeepholeSrc, false));
|
|
} else {
|
|
DenseMap<unsigned, std::pair<unsigned, unsigned> >::iterator DI =
|
|
PeepholeDoubleRegsMap.find(SrcReg);
|
|
if (DI != PeepholeDoubleRegsMap.end()) {
|
|
std::pair<unsigned,unsigned> PeepholeSrc = DI->second;
|
|
MI.RemoveOperand(1);
|
|
MI.addOperand(MachineOperand::CreateReg(
|
|
PeepholeSrc.first, false /*isDef*/, false /*isImp*/,
|
|
false /*isKill*/, false /*isDead*/, false /*isUndef*/,
|
|
false /*isEarlyClobber*/, PeepholeSrc.second));
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Look for Predicated instructions.
|
|
if (!DisablePNotP) {
|
|
bool Done = false;
|
|
if (QII->isPredicated(MI)) {
|
|
MachineOperand &Op0 = MI.getOperand(0);
|
|
unsigned Reg0 = Op0.getReg();
|
|
const TargetRegisterClass *RC0 = MRI->getRegClass(Reg0);
|
|
if (RC0->getID() == Hexagon::PredRegsRegClassID) {
|
|
// Handle instructions that have a prediate register in op0
|
|
// (most cases of predicable instructions).
|
|
if (TargetRegisterInfo::isVirtualRegister(Reg0)) {
|
|
// Try to find in the map.
|
|
if (unsigned PeepholeSrc = PeepholeMap.lookup(Reg0)) {
|
|
// Change the 1st operand and, flip the opcode.
|
|
MI.getOperand(0).setReg(PeepholeSrc);
|
|
int NewOp = QII->getInvertedPredicatedOpcode(MI.getOpcode());
|
|
MI.setDesc(QII->get(NewOp));
|
|
Done = true;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if (!Done) {
|
|
// Handle special instructions.
|
|
unsigned Op = MI.getOpcode();
|
|
unsigned NewOp = 0;
|
|
unsigned PR = 1, S1 = 2, S2 = 3; // Operand indices.
|
|
|
|
switch (Op) {
|
|
case Hexagon::C2_mux:
|
|
case Hexagon::C2_muxii:
|
|
NewOp = Op;
|
|
break;
|
|
case Hexagon::C2_muxri:
|
|
NewOp = Hexagon::C2_muxir;
|
|
break;
|
|
case Hexagon::C2_muxir:
|
|
NewOp = Hexagon::C2_muxri;
|
|
break;
|
|
}
|
|
if (NewOp) {
|
|
unsigned PSrc = MI.getOperand(PR).getReg();
|
|
if (unsigned POrig = PeepholeMap.lookup(PSrc)) {
|
|
MI.getOperand(PR).setReg(POrig);
|
|
MI.setDesc(QII->get(NewOp));
|
|
// Swap operands S1 and S2.
|
|
MachineOperand Op1 = MI.getOperand(S1);
|
|
MachineOperand Op2 = MI.getOperand(S2);
|
|
ChangeOpInto(MI.getOperand(S1), Op2);
|
|
ChangeOpInto(MI.getOperand(S2), Op1);
|
|
}
|
|
} // if (NewOp)
|
|
} // if (!Done)
|
|
|
|
} // if (!DisablePNotP)
|
|
|
|
} // Instruction
|
|
} // Basic Block
|
|
return true;
|
|
}
|
|
|
|
void HexagonPeephole::ChangeOpInto(MachineOperand &Dst, MachineOperand &Src) {
|
|
assert (&Dst != &Src && "Cannot duplicate into itself");
|
|
switch (Dst.getType()) {
|
|
case MachineOperand::MO_Register:
|
|
if (Src.isReg()) {
|
|
Dst.setReg(Src.getReg());
|
|
Dst.setSubReg(Src.getSubReg());
|
|
} else if (Src.isImm()) {
|
|
Dst.ChangeToImmediate(Src.getImm());
|
|
} else {
|
|
llvm_unreachable("Unexpected src operand type");
|
|
}
|
|
break;
|
|
|
|
case MachineOperand::MO_Immediate:
|
|
if (Src.isImm()) {
|
|
Dst.setImm(Src.getImm());
|
|
} else if (Src.isReg()) {
|
|
Dst.ChangeToRegister(Src.getReg(), Src.isDef(), Src.isImplicit(),
|
|
Src.isKill(), Src.isDead(), Src.isUndef(),
|
|
Src.isDebug());
|
|
Dst.setSubReg(Src.getSubReg());
|
|
} else {
|
|
llvm_unreachable("Unexpected src operand type");
|
|
}
|
|
break;
|
|
|
|
default:
|
|
llvm_unreachable("Unexpected dst operand type");
|
|
break;
|
|
}
|
|
}
|
|
|
|
FunctionPass *llvm::createHexagonPeephole() {
|
|
return new HexagonPeephole();
|
|
}
|