llvm/lib at 28127ffb510e58d8b52b389279aab05c8f99a590 - llvm

RPCS3/llvm

mirror of https://github.com/RPCS3/llvm.git synced 2025-01-12 15:30:56 +00:00

History

Robin Morisset 28127ffb51 [X86] Fix a bug with fetch_add(INT32_MIN)

Summary:
Fix pr21099

The pseudocode of what we were doing (spread through two functions) was:
if (operand.doesNotFitIn32Bits())
  Opc.initializeWithFoo();
if (operand < 0)
  operand = -operand;
if (operand.doesFitIn8Bits())
  Opc.initializeWithBar();
else if (operand.doesFitIn32Bits())
  Opc.initializeWithBlah();
doStuff(Opc);

So for operand == INT32_MIN, Opc was never initialized because the operand changes
from fitting in 32 bits to not fitting, causing the various bugs/error messages
noted by pr21099.

This patch adds an extra test at the beginning for this case, and an
llvm_unreachable to have better error message if the operand ends up
not fitting in 32-bits at the end.

Test Plan: new test + make check

Reviewers: jfb

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D5655

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@219257 91177308-0d34-0410-b5e6-96231b3b80d8

2014-10-07 23:53:57 +00:00

Analysis

[BasicAA] Revert "Revert r218714 - Make better use of zext and sign information."

2014-10-06 18:37:59 +00:00

AsmParser

Make CallingConv::ID an alias of "unsigned".

2014-09-10 18:00:17 +00:00

Bitcode

Do not destroy external linkage when deleting function body

2014-09-23 12:54:19 +00:00

CodeGen

typos