1
0
mirror of https://github.com/RPCS3/llvm.git synced 2024-12-27 22:55:15 +00:00
llvm/tools
Rafael Espindola 68016e0a6e Use the DiagnosticHandler to print diagnostics when reading bitcode.
The bitcode reading interface used std::error_code to report an error to the
callers and it is the callers job to print diagnostics.

This is not ideal for error handling or diagnostic reporting:

* For error handling, all that the callers care about is 3 possibilities:
  * It worked
  * The bitcode file is corrupted/invalid.
  * The file is not bitcode at all.

* For diagnostic, it is user friendly to include far more information
  about the invalid case so the user can find out what is wrong with the
  bitcode file. This comes up, for example, when a developer introduces a
  bug while extending the format.

The compromise we had was to have a lot of error codes.

With this patch we use the DiagnosticHandler to communicate with the
human and std::error_code to communicate with the caller.

This allows us to have far fewer error codes and adds the infrastructure to
print better diagnostics. This is so because the diagnostics are printed when
he issue is found. The code that detected the problem in alive in the stack and
can pass down as much context as needed. As an example the patch updates
test/Bitcode/invalid.ll.

Using a DiagnosticHandler also moves the fatal/non-fatal error decision to the
caller. A simple one like llvm-dis can just use fatal errors. The gold plugin
needs a bit more complex treatment because of being passed non-bitcode files. An
hypothetical interactive tool would make all bitcode errors non-fatal.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@225562 91177308-0d34-0410-b5e6-96231b3b80d8
2015-01-10 00:07:30 +00:00
..
bugpoint Fix style. 2014-11-07 21:30:36 +00:00
bugpoint-passes [CMake] Add LLVM_LINK_COMPONENTS to loadable modules, LLVMHello and BugpointPasses, on Win32. 2014-07-13 13:36:48 +00:00
dsymutil Fix uninitialized memory read in llvm-dsymutil for the second time. 2015-01-07 21:13:30 +00:00
gold Use the DiagnosticHandler to print diagnostics when reading bitcode. 2015-01-10 00:07:30 +00:00
llc Remove an unnecessary reference variable that pointed to a unique_ptr variable. Just use the unique_ptr variable directly. 2014-12-12 07:52:06 +00:00
lli Silence gcc 4.9.1 warning 'xyz' is used uninitialized in this function. 2014-12-12 11:07:51 +00:00
llvm-ar Manually specify the folder that llvm-ranlib should reside in for CMake-produced solutions that care about such things (like MSVC). This takes llvm-ranlib out of the root solution folder and places it into the Tools folder where it belongs. 2015-01-07 14:19:15 +00:00
llvm-as Modernize raw_fd_ostream's constructor a bit. 2014-08-25 18:16:47 +00:00
llvm-bcanalyzer Revert "Bitcode: Move the DEBUG_LOC record to DEBUG_LOC_OLD" 2015-01-09 17:53:27 +00:00
llvm-c-test Have llvm-c-test only use libLLVM if libLLVM has all the right components. 2014-12-18 21:03:49 +00:00
llvm-config [cmake] Teach the llvm-config program to respect LLVM_LIBDIR_SUFFIX. 2014-12-29 11:16:25 +00:00
llvm-cov Remove unused includes and out of date comment. NFC. 2014-12-17 03:07:20 +00:00
llvm-diff Return a std::unique_ptr from the IRReader.h functions. NFC. 2014-08-26 17:29:46 +00:00
llvm-dis Use the DiagnosticHandler to print diagnostics when reading bitcode. 2015-01-10 00:07:30 +00:00
llvm-dwarfdump Remove unused includes and out of date comment. NFC. 2014-12-17 03:07:20 +00:00
llvm-extract Remove redundant calls to isMaterializable. 2014-11-01 16:46:18 +00:00
llvm-go Teach LLVM about llgo subproject. 2014-11-27 00:15:21 +00:00
llvm-jitlistener Fix line mapping information in LLVM JIT profiling with Vtune 2014-12-15 04:45:43 +00:00
llvm-link Make it easier to pass a custom diagnostic handler to the IR linker. 2014-10-27 23:02:10 +00:00
llvm-lto llvm-lto: Add testing coverage for local contexts 2014-12-17 02:00:38 +00:00
llvm-mc Remove unused includes and out of date comment. NFC. 2014-12-17 03:07:20 +00:00
llvm-mcmarkup Explicitly pass ownership of the MemoryBuffer to AddNewSourceBuffer using std::unique_ptr 2014-08-21 20:44:56 +00:00
llvm-nm Return ErrorOr<std::unique_ptr<Archive>> form getAsArchive. 2014-12-09 21:05:36 +00:00
llvm-objdump Fix an ASAN failure introduced with r225537 (adding the -universal-headers to llvm-obdump). 2015-01-09 21:55:03 +00:00
llvm-profdata Use ErrorOr for the ::create factory on instrumented and sample profilers. 2014-11-03 00:51:45 +00:00
llvm-readobj llvm-readobj: add support to dump COFF export tables 2015-01-03 21:35:09 +00:00
llvm-rtdyld [MCJIT] Update CMakeLists.txt for llvm-rtdyld to add Object as a requirement. 2014-11-27 04:18:50 +00:00
llvm-shlib [cmake] Start making LLVM_LIBDIR_SUFFIX effective by adding it to 2014-12-29 11:16:19 +00:00
llvm-size Return ErrorOr<std::unique_ptr<Archive>> form getAsArchive. 2014-12-09 21:05:36 +00:00
llvm-stress Modernize raw_fd_ostream's constructor a bit. 2014-08-25 18:16:47 +00:00
llvm-symbolizer llvm-symbolizer: teach it about PowerPC64 ELF function descriptors 2014-11-07 09:08:39 +00:00
llvm-vtabledump llvm-vtabledump: Handle Itanium VTables 2014-11-03 07:23:25 +00:00
lto Unbreak cmake build with shared libraries enabled. 2014-12-20 01:51:02 +00:00
macho-dump Add printing the LC_LINKER_OPTION load command with llvm-objdump’s -private-headers. 2014-12-18 00:53:40 +00:00
msbuild MSBuild integration: fix the loop in install.bat 2014-09-30 22:30:06 +00:00
obj2yaml obj2yaml, yaml2obj: Add support for COFF executables 2014-11-14 08:15:42 +00:00
opt [PM] Give slightly less horrible names to the utility pass templates for 2015-01-07 11:14:51 +00:00
verify-uselistorder Prologue support 2014-12-03 02:08:38 +00:00
yaml2obj Remove StringMap::GetOrCreateValue in favor of StringMap::insert 2014-11-19 05:49:42 +00:00
CMakeLists.txt Initial dsymutil tool commit. 2014-12-12 17:31:24 +00:00
LLVMBuild.txt Initial dsymutil tool commit. 2014-12-12 17:31:24 +00:00
Makefile Initial dsymutil tool commit. 2014-12-12 17:31:24 +00:00