llvm/test/FileCheck
Thomas Preud'homme 4a42ca4771 FileCheck [2/12]: Stricter parsing of -D option
Summary:
This patch is part of a patch series to add support for FileCheck
numeric expressions. This specific patch gives earlier and better
diagnostics for the -D option.

Prior to this change, parsing of -D option was very loose: it assumed
that there is an equal sign (which to be fair is now checked by the
FileCheck executable) and that the part on the left of the equal sign
was a valid variable name. This commit adds logic to ensure that this
is the case and gives diagnostic when it is not, making it clear that
the issue came from a command-line option error. This is achieved by
sharing the variable parsing code into a new function ParseVariable.

Copyright:
    - Linaro (changes up to diff 183612 of revision D55940)
    - GraphCore (changes in later versions of revision D55940 and
                 in new revision created off D55940)

Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk

Subscribers: hiraditya, llvm-commits, probinson, dblaikie, grimar, arichardson, tra, rnk, kristina, hfinkel, rogfer01, JonChesterfield

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D60382

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@359447 91177308-0d34-0410-b5e6-96231b3b80d8
2019-04-29 13:32:36 +00:00
..
check-a-b-has-b.txt
check-b-a-has-b.txt
check-count.txt [FileCheck] introduce CHECK-COUNT-<num> repetition directive 2018-11-13 00:46:13 +00:00
check-dag-multi-prefix-2.txt
check-dag-multi-prefix.txt
check-dag-not-dag.txt [FileCheck] Fix search ranges for DAG-NOT-DAG 2018-07-20 20:09:56 +00:00
check-dag-overlap-torture.txt [FileCheck] Don't permit overlapping CHECK-DAG 2018-07-11 20:27:27 +00:00
check-dag-overlap.txt [FileCheck] Fix search ranges for DAG-NOT-DAG 2018-07-20 20:09:56 +00:00
check-dag-substring-prefix.txt
check-dag-xfails.txt
check-dag.txt
check-empty2.txt
check-empty-tag.txt
check-empty.txt Fixup test after r352704 since it changes how paths may be emitted. 2019-01-31 07:58:34 +00:00
check-label-dag-capture.txt
check-label-dag.txt [FileCheck] Implement -v and -vv for tracing matches 2018-07-13 03:08:23 +00:00
check-label.txt
check-multi-prefix-label.txt
check-multiple-prefixes-mixed.txt
check-multiple-prefixes-nomatch-2.txt [FileCheck] Implement -v and -vv for tracing matches 2018-07-13 03:08:23 +00:00
check-multiple-prefixes-nomatch.txt [FileCheck] Implement -v and -vv for tracing matches 2018-07-13 03:08:23 +00:00
check-multiple-prefixes-substr.txt
check-not-diaginfo.txt [FileCheck] Implement -v and -vv for tracing matches 2018-07-13 03:08:23 +00:00
check-prefixes.txt
check-substring-multi-prefix-2.txt
check-substring-multi-prefix.txt
defines.txt FileCheck [2/12]: Stricter parsing of -D option 2019-04-29 13:32:36 +00:00
dos-style-eol.txt
dump-input-annotations.txt [FileCheck] Suppress old -v/-vv diags if dumping input 2019-01-22 21:41:42 +00:00
dump-input-enable.txt Fixup test after r352704 since it changes how paths may be emitted. 2019-01-31 07:58:34 +00:00
empty-regex-match-at-start.txt [FileCheck]Remove assertions that prevent matching an empty string at file start before CHECK-NEXT/SAME 2019-03-12 15:37:34 +00:00
envvar-opts.txt [FileCheck] Try to fix windows bots broken by r346272 2018-11-06 22:42:10 +00:00
first-character-match.txt
implicit-check-not.txt [FileCheck] Implement -v and -vv for tracing matches 2018-07-13 03:08:23 +00:00
line-count-2.txt
line-count.txt
lit.local.cfg [FileCheck] Don't propagate FILECHECK_DUMP_INPUT_ON_FAILURE and 2019-01-10 17:24:06 +00:00
match-full-lines.txt [FileCheck] Implement -v and -vv for tracing matches 2018-07-13 03:08:23 +00:00
multiple-missing-prefixes.txt
next-no-match.txt
no-check-file.txt [FileCheck] Annotate input dump (1/7) 2018-12-18 00:01:39 +00:00
no-multi-suffixes.txt
opt-color.txt [SourceMgr][FileCheck] Obey -color by extending WithColor 2018-10-24 21:46:42 +00:00
regex-brackets.txt
regex-no-match.txt
regex-scope.txt
same.txt
separate-multi-prefix.txt
simple-var-capture.txt
two-checks-for-same-match.txt
validate-check-prefix.txt
var-ref-same-line.txt
verbose.txt [FileCheck] Implement -v and -vv for tracing matches 2018-07-13 03:08:23 +00:00