mirror of
https://github.com/RPCS3/llvm.git
synced 2025-04-14 03:50:48 +00:00

This is a partial re-commit -- maybe more of a re-implementation -- of r265631 (reverted in r265637). This makes RF_IgnoreMissingLocals behave (almost) consistently between the Value and the Metadata hierarchy. In particular: - MapValue returns nullptr or "metadata !{}" for missing locals in MetadataAsValue/LocalAsMetadata bridging paris, depending on the RF_IgnoreMissingLocals flag. - MapValue doesn't memoize LocalAsMetadata-related results. - MapMetadata no longer deals with LocalAsMetadata or RF_IgnoreMissingLocals at all. (This wasn't in r265631 at all, but I realized during testing it would make the patch simpler with no loss of generality.) r265631 went too far, making both functions universally ignore RF_IgnoreMissingLocals. This broke building (e.g.) compiler-rt. Reassociate (and possibly other passes) don't currently maintain dominates-use invariants for metadata operands, resulting in IR like this: define void @foo(i32 %arg) { call void @llvm.some.intrinsic(metadata i32 %x) %x = add i32 1, i32 %arg } If the inliner chooses to inline @foo into another function, then RemapInstruction will call `MapValue(metadata i32 %x)` and assert that the return is not nullptr. I've filed PR27273 to add a Verifier check and fix the underlying problem in the optimization passes. As a workaround, return `!{}` instead of nullptr for unmapped LocalAsMetadata when RF_IgnoreMissingLocals is unset. Otherwise, match the behaviour of r265631. Original commit message: ValueMapper: Make LocalAsMetadata match function-local Values Start treating LocalAsMetadata similarly to function-local members of the Value hierarchy in MapValue and MapMetadata. - Don't memoize them. - Return nullptr if they are missing. This also cleans up ConstantAsMetadata to stop listening to the RF_IgnoreMissingLocals flag. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@265759 91177308-0d34-0410-b5e6-96231b3b80d8
238 lines
7.0 KiB
C++
238 lines
7.0 KiB
C++
//===- ValueMapper.cpp - Unit tests for ValueMapper -----------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/IR/Function.h"
|
|
#include "llvm/IR/LLVMContext.h"
|
|
#include "llvm/IR/Metadata.h"
|
|
#include "llvm/Transforms/Utils/ValueMapper.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
|
|
TEST(ValueMapperTest, MapMetadata) {
|
|
LLVMContext Context;
|
|
auto *U = MDTuple::get(Context, None);
|
|
|
|
// The node should be unchanged.
|
|
ValueToValueMapTy VM;
|
|
EXPECT_EQ(U, MapMetadata(U, VM, RF_None));
|
|
}
|
|
|
|
TEST(ValueMapperTest, MapMetadataCycle) {
|
|
LLVMContext Context;
|
|
MDNode *U0;
|
|
MDNode *U1;
|
|
{
|
|
Metadata *Ops[] = {nullptr};
|
|
auto T = MDTuple::getTemporary(Context, Ops);
|
|
Ops[0] = T.get();
|
|
U0 = MDTuple::get(Context, Ops);
|
|
T->replaceOperandWith(0, U0);
|
|
U1 = MDNode::replaceWithUniqued(std::move(T));
|
|
U0->resolveCycles();
|
|
}
|
|
|
|
EXPECT_TRUE(U0->isResolved());
|
|
EXPECT_TRUE(U0->isUniqued());
|
|
EXPECT_TRUE(U1->isResolved());
|
|
EXPECT_TRUE(U1->isUniqued());
|
|
EXPECT_EQ(U1, U0->getOperand(0));
|
|
EXPECT_EQ(U0, U1->getOperand(0));
|
|
|
|
// Cycles shouldn't be duplicated.
|
|
{
|
|
ValueToValueMapTy VM;
|
|
EXPECT_EQ(U0, MapMetadata(U0, VM, RF_None));
|
|
EXPECT_EQ(U1, MapMetadata(U1, VM, RF_None));
|
|
}
|
|
|
|
// Check the other order.
|
|
{
|
|
ValueToValueMapTy VM;
|
|
EXPECT_EQ(U1, MapMetadata(U1, VM, RF_None));
|
|
EXPECT_EQ(U0, MapMetadata(U0, VM, RF_None));
|
|
}
|
|
}
|
|
|
|
TEST(ValueMapperTest, MapMetadataUnresolved) {
|
|
LLVMContext Context;
|
|
TempMDTuple T = MDTuple::getTemporary(Context, None);
|
|
|
|
ValueToValueMapTy VM;
|
|
EXPECT_EQ(T.get(), MapMetadata(T.get(), VM, RF_NoModuleLevelChanges));
|
|
}
|
|
|
|
TEST(ValueMapperTest, MapMetadataDistinct) {
|
|
LLVMContext Context;
|
|
auto *D = MDTuple::getDistinct(Context, None);
|
|
|
|
{
|
|
// The node should be cloned.
|
|
ValueToValueMapTy VM;
|
|
EXPECT_NE(D, MapMetadata(D, VM, RF_None));
|
|
}
|
|
{
|
|
// The node should be moved.
|
|
ValueToValueMapTy VM;
|
|
EXPECT_EQ(D, MapMetadata(D, VM, RF_MoveDistinctMDs));
|
|
}
|
|
}
|
|
|
|
TEST(ValueMapperTest, MapMetadataDistinctOperands) {
|
|
LLVMContext Context;
|
|
Metadata *Old = MDTuple::getDistinct(Context, None);
|
|
auto *D = MDTuple::getDistinct(Context, Old);
|
|
ASSERT_EQ(Old, D->getOperand(0));
|
|
|
|
Metadata *New = MDTuple::getDistinct(Context, None);
|
|
ValueToValueMapTy VM;
|
|
VM.MD()[Old].reset(New);
|
|
|
|
// Make sure operands are updated.
|
|
EXPECT_EQ(D, MapMetadata(D, VM, RF_MoveDistinctMDs));
|
|
EXPECT_EQ(New, D->getOperand(0));
|
|
}
|
|
|
|
TEST(ValueMapperTest, MapMetadataSeeded) {
|
|
LLVMContext Context;
|
|
auto *D = MDTuple::getDistinct(Context, None);
|
|
|
|
// The node should be moved.
|
|
ValueToValueMapTy VM;
|
|
EXPECT_EQ(None, VM.getMappedMD(D));
|
|
|
|
VM.MD().insert(std::make_pair(D, TrackingMDRef(D)));
|
|
EXPECT_EQ(D, *VM.getMappedMD(D));
|
|
EXPECT_EQ(D, MapMetadata(D, VM, RF_None));
|
|
}
|
|
|
|
TEST(ValueMapperTest, MapMetadataSeededWithNull) {
|
|
LLVMContext Context;
|
|
auto *D = MDTuple::getDistinct(Context, None);
|
|
|
|
// The node should be moved.
|
|
ValueToValueMapTy VM;
|
|
EXPECT_EQ(None, VM.getMappedMD(D));
|
|
|
|
VM.MD().insert(std::make_pair(D, TrackingMDRef()));
|
|
EXPECT_EQ(nullptr, *VM.getMappedMD(D));
|
|
EXPECT_EQ(nullptr, MapMetadata(D, VM, RF_None));
|
|
}
|
|
|
|
TEST(ValueMapperTest, MapMetadataNullMapGlobalWithIgnoreMissingLocals) {
|
|
LLVMContext C;
|
|
FunctionType *FTy =
|
|
FunctionType::get(Type::getVoidTy(C), Type::getInt8Ty(C), false);
|
|
std::unique_ptr<Function> F(
|
|
Function::Create(FTy, GlobalValue::ExternalLinkage, "F"));
|
|
|
|
ValueToValueMapTy VM;
|
|
RemapFlags Flags = RF_IgnoreMissingLocals | RF_NullMapMissingGlobalValues;
|
|
EXPECT_EQ(nullptr, MapValue(F.get(), VM, Flags));
|
|
}
|
|
|
|
TEST(ValueMapperTest, MapMetadataConstantAsMetadata) {
|
|
LLVMContext C;
|
|
FunctionType *FTy =
|
|
FunctionType::get(Type::getVoidTy(C), Type::getInt8Ty(C), false);
|
|
std::unique_ptr<Function> F(
|
|
Function::Create(FTy, GlobalValue::ExternalLinkage, "F"));
|
|
|
|
auto *CAM = ConstantAsMetadata::get(F.get());
|
|
{
|
|
ValueToValueMapTy VM;
|
|
EXPECT_EQ(CAM, MapMetadata(CAM, VM));
|
|
EXPECT_TRUE(VM.MD().count(CAM));
|
|
VM.MD().erase(CAM);
|
|
EXPECT_EQ(CAM, MapMetadata(CAM, VM, RF_IgnoreMissingLocals));
|
|
EXPECT_TRUE(VM.MD().count(CAM));
|
|
|
|
auto *N = MDTuple::get(C, None);
|
|
VM.MD()[CAM].reset(N);
|
|
EXPECT_EQ(N, MapMetadata(CAM, VM));
|
|
EXPECT_EQ(N, MapMetadata(CAM, VM, RF_IgnoreMissingLocals));
|
|
}
|
|
|
|
std::unique_ptr<Function> F2(
|
|
Function::Create(FTy, GlobalValue::ExternalLinkage, "F2"));
|
|
ValueToValueMapTy VM;
|
|
VM[F.get()] = F2.get();
|
|
auto *F2MD = MapMetadata(CAM, VM);
|
|
EXPECT_TRUE(VM.MD().count(CAM));
|
|
EXPECT_TRUE(F2MD);
|
|
EXPECT_EQ(F2.get(), cast<ConstantAsMetadata>(F2MD)->getValue());
|
|
}
|
|
|
|
#ifdef GTEST_HAS_DEATH_TEST
|
|
#ifndef NDEBUG
|
|
TEST(ValueMapperTest, MapMetadataLocalAsMetadata) {
|
|
LLVMContext C;
|
|
FunctionType *FTy =
|
|
FunctionType::get(Type::getVoidTy(C), Type::getInt8Ty(C), false);
|
|
std::unique_ptr<Function> F(
|
|
Function::Create(FTy, GlobalValue::ExternalLinkage, "F"));
|
|
Argument &A = *F->arg_begin();
|
|
|
|
// MapMetadata doesn't support LocalAsMetadata. The only valid container for
|
|
// LocalAsMetadata is a MetadataAsValue instance, so use it directly.
|
|
auto *LAM = LocalAsMetadata::get(&A);
|
|
ValueToValueMapTy VM;
|
|
EXPECT_DEATH(MapMetadata(LAM, VM), "Unexpected local metadata");
|
|
EXPECT_DEATH(MapMetadata(LAM, VM, RF_IgnoreMissingLocals),
|
|
"Unexpected local metadata");
|
|
}
|
|
#endif
|
|
#endif
|
|
|
|
TEST(ValueMapperTest, MapValueLocalAsMetadata) {
|
|
LLVMContext C;
|
|
FunctionType *FTy =
|
|
FunctionType::get(Type::getVoidTy(C), Type::getInt8Ty(C), false);
|
|
std::unique_ptr<Function> F(
|
|
Function::Create(FTy, GlobalValue::ExternalLinkage, "F"));
|
|
Argument &A = *F->arg_begin();
|
|
|
|
auto *LAM = LocalAsMetadata::get(&A);
|
|
auto *MAV = MetadataAsValue::get(C, LAM);
|
|
|
|
// The principled answer to a LocalAsMetadata of an unmapped SSA value would
|
|
// be to return nullptr (regardless of RF_IgnoreMissingLocals).
|
|
//
|
|
// However, algorithms that use RemapInstruction assume that each instruction
|
|
// only references SSA values from previous instructions. Arguments of
|
|
// such as "metadata i32 %x" don't currently successfully maintain that
|
|
// property. To keep RemapInstruction from crashing we need a non-null
|
|
// return here, but we also shouldn't reference the unmapped local. Use
|
|
// "metadata !{}".
|
|
auto *N0 = MDTuple::get(C, None);
|
|
auto *N0AV = MetadataAsValue::get(C, N0);
|
|
ValueToValueMapTy VM;
|
|
EXPECT_EQ(N0AV, MapValue(MAV, VM));
|
|
EXPECT_EQ(nullptr, MapValue(MAV, VM, RF_IgnoreMissingLocals));
|
|
EXPECT_FALSE(VM.count(MAV));
|
|
EXPECT_FALSE(VM.count(&A));
|
|
EXPECT_EQ(None, VM.getMappedMD(LAM));
|
|
|
|
VM[MAV] = MAV;
|
|
EXPECT_EQ(MAV, MapValue(MAV, VM));
|
|
EXPECT_EQ(MAV, MapValue(MAV, VM, RF_IgnoreMissingLocals));
|
|
EXPECT_TRUE(VM.count(MAV));
|
|
EXPECT_FALSE(VM.count(&A));
|
|
|
|
VM[MAV] = &A;
|
|
EXPECT_EQ(&A, MapValue(MAV, VM));
|
|
EXPECT_EQ(&A, MapValue(MAV, VM, RF_IgnoreMissingLocals));
|
|
EXPECT_TRUE(VM.count(MAV));
|
|
EXPECT_FALSE(VM.count(&A));
|
|
}
|
|
|
|
} // end namespace
|